AWS SDK

AWS SDK

rev. 628eeeeeed390f5efdbfe607c18848c033debd3e (ignoring whitespace)

Files changed:

tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/header-signed-request.txt

@@ -0,1 +0,10 @@
           1  +
POST / HTTP/1.1
           2  +
Content-Type:application/x-www-form-urlencoded
           3  +
Host:example.amazonaws.com
           4  +
Content-Length:13
           5  +
X-Amz-Date:20150830T123600Z
           6  +
X-Amz-Region-Set:us-east-1
           7  +
x-amz-content-sha256:9095672bbd1f56dfc5b65f3e153adc8731a4a654192329106275f4c7b24d0b6e
           8  +
Authorization:AWS4-ECDSA-P256-SHA256 Credential=AKIDEXAMPLE/20150830/service/aws4_request, SignedHeaders=content-length;content-type;host;x-amz-content-sha256;x-amz-date;x-amz-region-set, Signature=3045022100955bbc0f0b9d4284719808642167f7d5ea4a72f8c296b75b442898c8b81cd7e502202425fb97620fa9a20344d22b248dd00db07524fc39b5ad77533e00b277331241
           9  +
          10  +
Param1=value1

tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/header-string-to-sign.txt

@@ -0,1 +0,4 @@
           1  +
AWS4-ECDSA-P256-SHA256
           2  +
20150830T123600Z
           3  +
20150830/service/aws4_request
           4  +
ba7fa291aefad463b308fdc89b33d852aea9fbcfa151d820117bd8189066cb91

tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/public-key.json

@@ -0,1 +0,4 @@
           1  +
{
           2  +
  "X":"b6618f6a65740a99e650b33b6b4b5bd0d43b176d721a3edfea7e7d2d56d936b1",
           3  +
  "Y":"865ed22a7eadc9c5cb9d2cbaca1b3699139fedc5043dc6661864218330c8e518"
           4  +
}

tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/query-signature.txt

@@ -0,1 +3064,3420 @@
           1  +
304402205e21d399153f879b0f32c38742d12941299467bfdc213224cc76a97acffd6ec6022035a9be37a38c19e98e5cfc536fabe885e82fbf999081234b364cab5cacff8733
              \
 No newline at end of file
    0      2   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/query-signed-request.txt b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/query-signed-request.txt
    1      3   
new file mode 100644
    2      4   
index 0000000..71d6de9
    3         -
-- /dev/null
           5  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/query-signed-request.txt
    4      6   
@@ -0,0 +1,6 @@
           7  +
POST /?X-Amz-Algorithm=AWS4-ECDSA-P256-SHA256&X-Amz-Credential=AKIDEXAMPLE%2F20150830%2Fservice%2Faws4_request&X-Amz-Date=20150830T123600Z&X-Amz-SignedHeaders=content-length%3Bcontent-type%3Bhost&X-Amz-Expires=3600&X-Amz-Region-Set=us-east-1&X-Amz-Signature=30450221008d8a6aa0bc3f651e6c14c52e9e24dbca58964641c9cb6e55169f9dc74766ae3d022016126756ce1523ac972f66f6bf6e981f44572d3c8916f1f43d428fb2caa0e1ea HTTP/1.1
           8  +
Content-Type:application/x-www-form-urlencoded
           9  +
Host:example.amazonaws.com
          10  +
Content-Length:13
          11  +
          12  +
Param1=value1
              \
 No newline at end of file
    5     13   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-sig-v4a-test-suite/post-x-www-form-urlencoded/query-string-to-sign.txt b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/query-string-to-sign.txt
    6     14   
similarity index 99%
    7     15   
rename from tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-sig-v4a-test-suite/post-x-www-form-urlencoded/query-string-to-sign.txt
    8     16   
rename to tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/query-string-to-sign.txt
    9     17   
index bef3143..cc7a224 100644
   10     18   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/request.txt b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/request.txt
   11     19   
new file mode 100644
   12     20   
index 0000000..760b2d3
   13         -
-- /dev/null
          21  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/aws-signing-test-suite/v4a/post-x-www-form-urlencoded/request.txt
   14     22   
@@ -0,0 +1,6 @@
          23  +
POST / HTTP/1.1
          24  +
Content-Type:application/x-www-form-urlencoded
          25  +
Host:example.amazonaws.com
          26  +
Content-Length:13
          27  +
          28  +
Param1=value1
              \
 No newline at end of file
   15     29   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/canonical_request.rs b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/canonical_request.rs
   16     30   
index 9bd636f..b53f33f 100644
   17         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/canonical_request.rs
          31  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/canonical_request.rs
   18     32   
@@ -346,67 +346,78 @@ impl CanonicalRequest<'_> {
   19     33   
            params.push((Cow::Borrowed(k), Cow::Borrowed(v)));
   20     34   
        }
   21     35   
   22     36   
        if let SignatureValues::QueryParams(values) = values {
   23     37   
            add_param(&mut params, param::X_AMZ_DATE, &values.date_time);
   24     38   
            add_param(&mut params, param::X_AMZ_EXPIRES, &values.expires);
   25     39   
   26     40   
            #[cfg(feature = "sigv4a")]
   27     41   
            if let Some(regions) = values.region_set {
   28     42   
                add_param(&mut params, sigv4a::param::X_AMZ_REGION_SET, regions);
   29     43   
            }
   30     44   
   31     45   
            add_param(&mut params, param::X_AMZ_ALGORITHM, values.algorithm);
   32     46   
            add_param(&mut params, param::X_AMZ_CREDENTIAL, &values.credential);
   33     47   
            add_param(
   34     48   
                &mut params,
   35     49   
                param::X_AMZ_SIGNED_HEADERS,
   36     50   
                values.signed_headers.as_str(),
   37     51   
            );
   38     52   
   39     53   
            if let Some(security_token) = values.security_token {
   40     54   
                add_param(
   41     55   
                    &mut params,
   42     56   
                    settings
   43     57   
                        .session_token_name_override
   44     58   
                        .unwrap_or(param::X_AMZ_SECURITY_TOKEN),
   45     59   
                    security_token,
   46     60   
                );
   47     61   
            }
   48     62   
        }
   49         -
        // Sort by param name, and then by param value
          63  +
          64  +
        // Sort on the _encoded_ key/value pairs
          65  +
        let mut params: Vec<(String, String)> = params
          66  +
            .into_iter()
          67  +
            .map(|x| {
          68  +
                use aws_smithy_http::query::fmt_string;
          69  +
                let enc_k = fmt_string(&x.0);
          70  +
                let enc_v = fmt_string(&x.1);
          71  +
                (enc_k, enc_v)
          72  +
            })
          73  +
            .collect();
          74  +
   50     75   
        params.sort();
   51     76   
   52     77   
        let mut query = QueryWriter::new(uri);
   53     78   
        query.clear_params();
   54     79   
        for (key, value) in params {
   55         -
            query.insert(&key, &value);
          80  +
            query.insert_encoded(&key, &value);
   56     81   
        }
   57     82   
   58     83   
        let query = query.build_query();
   59     84   
        if query.is_empty() {
   60     85   
            None
   61     86   
        } else {
   62     87   
            Some(query)
   63     88   
        }
   64     89   
    }
   65     90   
   66     91   
    fn insert_host_header(
   67     92   
        canonical_headers: &mut HeaderMap<HeaderValue>,
   68     93   
        uri: &Uri,
   69     94   
    ) -> HeaderValue {
   70     95   
        match canonical_headers.get(&HOST) {
   71     96   
            Some(header) => header.clone(),
   72     97   
            None => {
   73     98   
                let port = uri.port();
   74     99   
                let scheme = uri.scheme();
   75    100   
                let authority = uri
   76    101   
                    .authority()
   77    102   
                    .expect("request uri authority must be set for signing")
   78    103   
                    .as_str();
   79    104   
                let host = uri
   80    105   
                    .host()
   81    106   
                    .expect("request uri host must be set for signing");
   82    107   
   83    108   
                // Check if port is default (80 for HTTP, 443 for HTTPS) and if so exclude it from the
   84    109   
                // Host header when signing since RFC 2616 indicates that the default port should not be
   85    110   
                // sent in the Host header (and Hyper strips default ports if they are present)
   86    111   
@@ -642,310 +653,320 @@ impl<'a> StringToSign<'a> {
   87    112   
            service,
   88    113   
            hashed_creq,
   89    114   
            signature_version: SignatureVersion::V4a,
   90    115   
        }
   91    116   
    }
   92    117   
}
   93    118   
   94    119   
impl fmt::Display for StringToSign<'_> {
   95    120   
    fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
   96    121   
        write!(
   97    122   
            f,
   98    123   
            "{}\n{}\n{}\n{}",
   99    124   
            self.algorithm,
  100    125   
            format_date_time(self.time),
  101    126   
            match self.signature_version {
  102    127   
                SignatureVersion::V4 => self.scope.to_string(),
  103    128   
                SignatureVersion::V4a => self.scope.v4a_display(),
  104    129   
            },
  105    130   
            self.hashed_creq
  106    131   
        )
  107    132   
    }
  108    133   
}
  109    134   
  110    135   
#[cfg(test)]
  111    136   
mod tests {
  112    137   
    use crate::date_time::test_parsers::parse_date_time;
  113    138   
    use crate::http_request::canonical_request::{
  114    139   
        normalize_header_value, trim_all, CanonicalRequest, SigningScope, StringToSign,
  115    140   
    };
  116    141   
    use crate::http_request::test;
         142  +
    use crate::http_request::test::SigningSuiteTest;
  117    143   
    use crate::http_request::{
  118    144   
        PayloadChecksumKind, SessionTokenMode, SignableBody, SignableRequest, SignatureLocation,
  119    145   
        SigningParams, SigningSettings,
  120    146   
    };
  121    147   
    use crate::sign::v4;
  122    148   
    use crate::sign::v4::sha256_hex_string;
  123    149   
    use aws_credential_types::Credentials;
  124    150   
    use aws_smithy_http::query_writer::QueryWriter;
  125    151   
    use aws_smithy_runtime_api::client::identity::Identity;
  126    152   
    use http0::{HeaderValue, Uri};
  127    153   
    use pretty_assertions::assert_eq;
  128    154   
    use proptest::{prelude::*, proptest};
  129    155   
    use std::borrow::Cow;
  130    156   
    use std::time::Duration;
  131    157   
  132    158   
    fn signing_params(identity: &Identity, settings: SigningSettings) -> SigningParams<'_> {
  133    159   
        v4::signing_params::Builder::default()
  134    160   
            .identity(identity)
  135    161   
            .region("test-region")
  136    162   
            .name("testservicename")
  137    163   
            .time(parse_date_time("20210511T154045Z").unwrap())
  138    164   
            .settings(settings)
  139    165   
            .build()
  140    166   
            .unwrap()
  141    167   
            .into()
  142    168   
    }
  143    169   
  144    170   
    #[test]
  145    171   
    fn test_repeated_header() {
  146         -
        let mut req = test::v4::test_request("get-vanilla-query-order-key-case");
         172  +
        let test = test::SigningSuiteTest::v4("get-vanilla-query-order-key-case");
         173  +
        let mut req = test.request();
  147    174   
        req.headers.push((
  148    175   
            "x-amz-object-attributes".to_string(),
  149    176   
            "Checksum".to_string(),
  150    177   
        ));
  151    178   
        req.headers.push((
  152    179   
            "x-amz-object-attributes".to_string(),
  153    180   
            "ObjectSize".to_string(),
  154    181   
        ));
  155    182   
        let req = SignableRequest::from(&req);
  156    183   
        let settings = SigningSettings {
  157    184   
            payload_checksum_kind: PayloadChecksumKind::XAmzSha256,
  158    185   
            session_token_mode: SessionTokenMode::Exclude,
  159    186   
            ..Default::default()
  160    187   
        };
  161    188   
        let identity = Credentials::for_tests().into();
  162    189   
        let signing_params = signing_params(&identity, settings);
  163    190   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  164    191   
  165    192   
        assert_eq!(
  166    193   
            creq.values.signed_headers().to_string(),
  167    194   
            "host;x-amz-content-sha256;x-amz-date;x-amz-object-attributes"
  168    195   
        );
  169    196   
        assert_eq!(
  170    197   
            creq.header_values_for("x-amz-object-attributes"),
  171    198   
            "Checksum,ObjectSize",
  172    199   
        );
  173    200   
    }
  174    201   
  175    202   
    #[test]
  176    203   
    fn test_host_header_properly_handles_ports() {
  177    204   
        fn host_header_test_setup(endpoint: String) -> String {
  178         -
            let mut req = test::v4::test_request("get-vanilla");
         205  +
            let test = SigningSuiteTest::v4("get-vanilla");
         206  +
            let mut req = test.request();
  179    207   
            req.uri = endpoint;
  180    208   
            let req = SignableRequest::from(&req);
  181    209   
            let settings = SigningSettings {
  182    210   
                payload_checksum_kind: PayloadChecksumKind::XAmzSha256,
  183    211   
                session_token_mode: SessionTokenMode::Exclude,
  184    212   
                ..Default::default()
  185    213   
            };
  186    214   
            let identity = Credentials::for_tests().into();
  187    215   
            let signing_params = signing_params(&identity, settings);
  188    216   
            let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  189    217   
            creq.header_values_for("host")
  190    218   
        }
  191    219   
  192    220   
        // HTTP request with 80 port should not be signed with that port
  193    221   
        let http_80_host_header = host_header_test_setup("http://localhost:80".into());
  194    222   
        assert_eq!(http_80_host_header, "localhost",);
  195    223   
  196    224   
        // HTTP request with non-80 port should be signed with that port
  197    225   
        let http_1234_host_header = host_header_test_setup("http://localhost:1234".into());
  198    226   
        assert_eq!(http_1234_host_header, "localhost:1234",);
  199    227   
  200    228   
        // HTTPS request with 443 port should not be signed with that port
  201    229   
        let https_443_host_header = host_header_test_setup("https://localhost:443".into());
  202    230   
        assert_eq!(https_443_host_header, "localhost",);
  203    231   
  204    232   
        // HTTPS request with non-443 port should be signed with that port
  205    233   
        let https_1234_host_header = host_header_test_setup("https://localhost:1234".into());
  206    234   
        assert_eq!(https_1234_host_header, "localhost:1234",);
  207    235   
    }
  208    236   
  209    237   
    #[test]
  210    238   
    fn test_set_xamz_sha_256() {
  211         -
        let req = test::v4::test_request("get-vanilla-query-order-key-case");
         239  +
        let test = SigningSuiteTest::v4("get-vanilla-query-order-key-case");
         240  +
        let req = test.request();
  212    241   
        let req = SignableRequest::from(&req);
  213    242   
        let settings = SigningSettings {
  214    243   
            payload_checksum_kind: PayloadChecksumKind::XAmzSha256,
  215    244   
            session_token_mode: SessionTokenMode::Exclude,
  216    245   
            ..Default::default()
  217    246   
        };
  218    247   
        let identity = Credentials::for_tests().into();
  219    248   
        let mut signing_params = signing_params(&identity, settings);
  220    249   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  221    250   
        assert_eq!(
  222    251   
            creq.values.content_sha256(),
  223    252   
            "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855"
  224    253   
        );
  225    254   
        // assert that the sha256 header was added
  226    255   
        assert_eq!(
  227    256   
            creq.values.signed_headers().as_str(),
  228    257   
            "host;x-amz-content-sha256;x-amz-date"
  229    258   
        );
  230    259   
  231    260   
        signing_params.set_payload_checksum_kind(PayloadChecksumKind::NoHeader);
  232    261   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  233    262   
        assert_eq!(creq.values.signed_headers().as_str(), "host;x-amz-date");
  234    263   
    }
  235    264   
  236    265   
    #[test]
  237    266   
    fn test_unsigned_payload() {
  238         -
        let mut req = test::v4::test_request("get-vanilla-query-order-key-case");
         267  +
        let test = SigningSuiteTest::v4("get-vanilla-query-order-key-case");
         268  +
        let mut req = test.request();
  239    269   
        req.set_body(SignableBody::UnsignedPayload);
  240    270   
        let req: SignableRequest<'_> = SignableRequest::from(&req);
  241    271   
  242    272   
        let settings = SigningSettings {
  243    273   
            payload_checksum_kind: PayloadChecksumKind::XAmzSha256,
  244    274   
            ..Default::default()
  245    275   
        };
  246    276   
        let identity = Credentials::for_tests().into();
  247    277   
        let signing_params = signing_params(&identity, settings);
  248    278   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  249    279   
        assert_eq!(creq.values.content_sha256(), "UNSIGNED-PAYLOAD");
  250    280   
        assert!(creq.to_string().ends_with("UNSIGNED-PAYLOAD"));
  251    281   
    }
  252    282   
  253    283   
    #[test]
  254    284   
    fn test_precomputed_payload() {
  255    285   
        let payload_hash = "44ce7dd67c959e0d3524ffac1771dfbba87d2b6b4b4e99e42034a8b803f8b072";
  256         -
        let mut req = test::v4::test_request("get-vanilla-query-order-key-case");
         286  +
        let test = SigningSuiteTest::v4("get-vanilla-query-order-key-case");
         287  +
        let mut req = test.request();
  257    288   
        req.set_body(SignableBody::Precomputed(String::from(payload_hash)));
  258    289   
        let req = SignableRequest::from(&req);
  259    290   
        let settings = SigningSettings {
  260    291   
            payload_checksum_kind: PayloadChecksumKind::XAmzSha256,
  261    292   
            ..Default::default()
  262    293   
        };
  263    294   
        let identity = Credentials::for_tests().into();
  264    295   
        let signing_params = signing_params(&identity, settings);
  265    296   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  266    297   
        assert_eq!(creq.values.content_sha256(), payload_hash);
  267    298   
        assert!(creq.to_string().ends_with(payload_hash));
  268    299   
    }
  269    300   
  270    301   
    #[test]
  271    302   
    fn test_generate_scope() {
  272    303   
        let expected = "20150830/us-east-1/iam/aws4_request\n";
  273    304   
        let scope = SigningScope {
  274    305   
            time: parse_date_time("20150830T123600Z").unwrap(),
  275    306   
            region: "us-east-1",
  276    307   
            service: "iam",
  277    308   
        };
  278    309   
        assert_eq!(format!("{}\n", scope), expected);
  279    310   
    }
  280    311   
  281    312   
    #[test]
  282    313   
    fn test_string_to_sign() {
  283    314   
        let time = parse_date_time("20150830T123600Z").unwrap();
  284         -
        let creq = test::v4::test_canonical_request("get-vanilla-query-order-key-case");
  285         -
        let expected_sts = test::v4::test_sts("get-vanilla-query-order-key-case");
         315  +
        let test = SigningSuiteTest::v4("get-vanilla-query-order-key-case");
         316  +
        let creq = test.canonical_request(SignatureLocation::Headers);
         317  +
        let expected_sts = test.string_to_sign(SignatureLocation::Headers);
  286    318   
        let encoded = sha256_hex_string(creq.as_bytes());
  287    319   
  288    320   
        let actual = StringToSign::new_v4(time, "us-east-1", "service", &encoded);
  289    321   
        assert_eq!(expected_sts, actual.to_string());
  290    322   
    }
  291    323   
  292    324   
    #[test]
  293    325   
    fn test_digest_of_canonical_request() {
  294         -
        let creq = test::v4::test_canonical_request("get-vanilla-query-order-key-case");
         326  +
        let test = SigningSuiteTest::v4("get-vanilla-query-order-key-case");
         327  +
        let creq = test.canonical_request(SignatureLocation::Headers);
  295    328   
        let expected = "816cd5b414d056048ba4f7c5386d6e0533120fb1fcfa93762cf0fc39e2cf19e0";
  296    329   
        let actual = sha256_hex_string(creq.as_bytes());
  297    330   
        assert_eq!(expected, actual);
  298    331   
    }
  299    332   
  300    333   
    #[test]
  301    334   
    fn test_double_url_encode_path() {
  302         -
        let req = test::v4::test_request("double-encode-path");
         335  +
        let test = SigningSuiteTest::v4("double-encode-path");
         336  +
        let req = test.request();
  303    337   
        let req = SignableRequest::from(&req);
  304    338   
        let identity = Credentials::for_tests().into();
  305    339   
        let signing_params = signing_params(&identity, SigningSettings::default());
  306    340   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  307    341   
  308         -
        let expected = test::v4::test_canonical_request("double-encode-path");
         342  +
        let expected = test.canonical_request(SignatureLocation::Headers);
  309    343   
        let actual = format!("{}", creq);
  310    344   
        assert_eq!(actual, expected);
  311    345   
    }
  312    346   
  313    347   
    #[test]
  314    348   
    fn test_double_url_encode() {
  315         -
        let req = test::v4::test_request("double-url-encode");
         349  +
        let test = SigningSuiteTest::v4("double-url-encode");
         350  +
        let req = test.request();
  316    351   
        let req = SignableRequest::from(&req);
  317    352   
        let identity = Credentials::for_tests().into();
  318    353   
        let signing_params = signing_params(&identity, SigningSettings::default());
  319    354   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  320         -
  321         -
        let expected = test::v4::test_canonical_request("double-url-encode");
         355  +
        let expected = test.canonical_request(SignatureLocation::Headers);
  322    356   
        let actual = format!("{}", creq);
  323    357   
        assert_eq!(actual, expected);
  324    358   
    }
  325    359   
  326    360   
    #[test]
  327    361   
    fn test_tilde_in_uri() {
  328    362   
        let req = http0::Request::builder()
  329    363   
            .uri("https://s3.us-east-1.amazonaws.com/my-bucket?list-type=2&prefix=~objprefix&single&k=&unreserved=-_.~").body("").unwrap().into();
  330    364   
        let req = SignableRequest::from(&req);
  331    365   
        let identity = Credentials::for_tests().into();
  332    366   
        let signing_params = signing_params(&identity, SigningSettings::default());
  333    367   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  334    368   
        assert_eq!(
  335    369   
            Some("k=&list-type=2&prefix=~objprefix&single=&unreserved=-_.~"),
  336    370   
            creq.params.as_deref(),
  337    371   
        );
  338    372   
    }
  339    373   
  340    374   
    #[test]
  341    375   
    fn test_signing_urls_with_percent_encoded_query_strings() {
  342    376   
        let all_printable_ascii_chars: String = (32u8..127).map(char::from).collect();
  343    377   
        let uri = Uri::from_static("https://s3.us-east-1.amazonaws.com/my-bucket");
  344    378   
  345    379   
        let mut query_writer = QueryWriter::new(&uri);
  346    380   
        query_writer.insert("list-type", "2");
  347    381   
        query_writer.insert("prefix", &all_printable_ascii_chars);
  348    382   
  349    383   
        let req = http0::Request::builder()
  350    384   
            .uri(query_writer.build_uri())
  351    385   
            .body("")
  352    386   
            .unwrap()
  353    387   
            .into();
  354    388   
        let req = SignableRequest::from(&req);
  355    389   
        let identity = Credentials::for_tests().into();
  356    390   
        let signing_params = signing_params(&identity, SigningSettings::default());
  357    391   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  358    392   
  359    393   
        let expected = "list-type=2&prefix=%20%21%22%23%24%25%26%27%28%29%2A%2B%2C-.%2F0123456789%3A%3B%3C%3D%3E%3F%40ABCDEFGHIJKLMNOPQRSTUVWXYZ%5B%5C%5D%5E_%60abcdefghijklmnopqrstuvwxyz%7B%7C%7D~";
  360    394   
        let actual = creq.params.unwrap();
  361    395   
        assert_eq!(expected, actual);
  362    396   
    }
  363    397   
  364    398   
    #[test]
  365    399   
    fn test_omit_session_token() {
  366         -
        let req = test::v4::test_request("get-vanilla-query-order-key-case");
         400  +
        let test = SigningSuiteTest::v4("get-vanilla-query-order-key-case");
         401  +
        let req = test.request();
  367    402   
        let req = SignableRequest::from(&req);
  368    403   
        let settings = SigningSettings {
  369    404   
            session_token_mode: SessionTokenMode::Include,
  370    405   
            ..Default::default()
  371    406   
        };
  372    407   
        let identity = Credentials::for_tests_with_session_token().into();
  373    408   
        let mut signing_params = signing_params(&identity, settings);
  374    409   
  375    410   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  376    411   
        assert_eq!(
  377    412   
            creq.values.signed_headers().as_str(),
  378    413   
            "host;x-amz-date;x-amz-security-token"
  379    414   
        );
  380    415   
        assert_eq!(
  381    416   
            creq.headers.get("x-amz-security-token").unwrap(),
  382    417   
            "notarealsessiontoken"
  383    418   
        );
  384    419   
  385    420   
        signing_params.set_session_token_mode(SessionTokenMode::Exclude);
  386    421   
        let creq = CanonicalRequest::from(&req, &signing_params).unwrap();
  387    422   
        assert_eq!(
  388    423   
            creq.headers.get("x-amz-security-token").unwrap(),
  389    424   
            "notarealsessiontoken"
  390    425   
        );
  391    426   
        assert_eq!(creq.values.signed_headers().as_str(), "host;x-amz-date");
  392    427   
    }
  393    428   
  394    429   
    // It should exclude authorization, user-agent, x-amzn-trace-id, and transfer-encoding headers from presigning
  395    430   
    #[test]
  396    431   
    fn non_presigning_header_exclusion() {
  397    432   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/sign.rs b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/sign.rs
  398    433   
index c4bbbee..363fc2c 100644
  399         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/sign.rs
         434  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/sign.rs
  400    435   
@@ -6,60 +6,62 @@
  401    436   
use super::error::SigningError;
  402    437   
use super::{PayloadChecksumKind, SignatureLocation};
  403    438   
use crate::http_request::canonical_request::header;
  404    439   
use crate::http_request::canonical_request::param;
  405    440   
use crate::http_request::canonical_request::{CanonicalRequest, StringToSign};
  406    441   
use crate::http_request::error::CanonicalRequestError;
  407    442   
use crate::http_request::SigningParams;
  408    443   
use crate::sign::v4;
  409    444   
#[cfg(feature = "sigv4a")]
  410    445   
use crate::sign::v4a;
  411    446   
use crate::{SignatureVersion, SigningOutput};
  412    447   
use http0::Uri;
  413    448   
use std::borrow::Cow;
  414    449   
use std::fmt::{Debug, Formatter};
  415    450   
use std::str;
  416    451   
  417    452   
const LOG_SIGNABLE_BODY: &str = "LOG_SIGNABLE_BODY";
  418    453   
  419    454   
/// Represents all of the information necessary to sign an HTTP request.
  420    455   
#[derive(Debug)]
  421    456   
#[non_exhaustive]
  422    457   
pub struct SignableRequest<'a> {
  423    458   
    method: &'a str,
  424    459   
    uri: Uri,
  425    460   
    headers: Vec<(&'a str, &'a str)>,
  426    461   
    body: SignableBody<'a>,
  427    462   
}
  428    463   
  429    464   
impl<'a> SignableRequest<'a> {
  430    465   
    /// Creates a new `SignableRequest`.
         466  +
    ///
         467  +
    /// NOTE: The `uri` is expected to already in encoded form.
  431    468   
    pub fn new(
  432    469   
        method: &'a str,
  433    470   
        uri: impl Into<Cow<'a, str>>,
  434    471   
        headers: impl Iterator<Item = (&'a str, &'a str)>,
  435    472   
        body: SignableBody<'a>,
  436    473   
    ) -> Result<Self, SigningError> {
  437    474   
        let uri = uri
  438    475   
            .into()
  439    476   
            .parse()
  440    477   
            .map_err(|e| SigningError::from(CanonicalRequestError::from(e)))?;
  441    478   
        let headers = headers.collect();
  442    479   
        Ok(Self {
  443    480   
            method,
  444    481   
            uri,
  445    482   
            headers,
  446    483   
            body,
  447    484   
        })
  448    485   
    }
  449    486   
  450    487   
    /// Returns the signable URI
  451    488   
    pub(crate) fn uri(&self) -> &Uri {
  452    489   
        &self.uri
  453    490   
    }
  454    491   
  455    492   
    /// Returns the signable HTTP method
  456    493   
    pub(crate) fn method(&self) -> &str {
  457    494   
        self.method
  458    495   
    }
  459    496   
  460    497   
    /// Returns the request headers
  461    498   
@@ -478,436 +480,324 @@ fn add_header(map: &mut Vec<Header>, key: &'static str, value: &str, sensitive:
  462    499   
        sensitive,
  463    500   
    });
  464    501   
}
  465    502   
  466    503   
// add signature to authorization header
  467    504   
// Authorization: algorithm Credential=access key ID/credential scope, SignedHeaders=SignedHeaders, Signature=signature
  468    505   
fn build_authorization_header(
  469    506   
    access_key: &str,
  470    507   
    creq: &CanonicalRequest<'_>,
  471    508   
    sts: StringToSign<'_>,
  472    509   
    signature: &str,
  473    510   
    signature_version: SignatureVersion,
  474    511   
) -> String {
  475    512   
    let scope = match signature_version {
  476    513   
        SignatureVersion::V4 => sts.scope.to_string(),
  477    514   
        SignatureVersion::V4a => sts.scope.v4a_display(),
  478    515   
    };
  479    516   
    format!(
  480    517   
        "{} Credential={}/{}, SignedHeaders={}, Signature={}",
  481    518   
        sts.algorithm,
  482    519   
        access_key,
  483    520   
        scope,
  484    521   
        creq.values.signed_headers().as_str(),
  485    522   
        signature
  486    523   
    )
  487    524   
}
  488    525   
#[cfg(test)]
  489    526   
mod tests {
  490    527   
    use crate::date_time::test_parsers::parse_date_time;
  491    528   
    use crate::http_request::sign::{add_header, SignableRequest};
         529  +
    use crate::http_request::test::SigningSuiteTest;
  492    530   
    use crate::http_request::{
  493         -
        sign, test, SessionTokenMode, SignableBody, SignatureLocation, SigningInstructions,
         531  +
        sign, SessionTokenMode, SignableBody, SignatureLocation, SigningInstructions,
  494    532   
        SigningSettings,
  495    533   
    };
  496    534   
    use crate::sign::v4;
  497    535   
    use aws_credential_types::Credentials;
  498    536   
    use http0::{HeaderValue, Request};
  499    537   
    use pretty_assertions::assert_eq;
  500    538   
    use proptest::proptest;
  501    539   
    use std::borrow::Cow;
  502    540   
    use std::iter;
  503         -
    use std::time::Duration;
  504    541   
  505    542   
    macro_rules! assert_req_eq {
  506    543   
        (http: $expected:expr, $actual:expr) => {
  507    544   
            let mut expected = ($expected).map(|_b|"body");
  508    545   
            let mut actual = ($actual).map(|_b|"body");
  509    546   
            make_headers_comparable(&mut expected);
  510    547   
            make_headers_comparable(&mut actual);
  511    548   
            assert_eq!(format!("{:?}", expected), format!("{:?}", actual));
  512    549   
        };
  513    550   
        ($expected:tt, $actual:tt) => {
  514    551   
            assert_req_eq!(http: ($expected).as_http_request(), $actual);
  515    552   
        };
  516    553   
    }
  517    554   
  518    555   
    pub(crate) fn make_headers_comparable<B>(request: &mut Request<B>) {
  519    556   
        for (_name, value) in request.headers_mut() {
  520    557   
            value.set_sensitive(false);
  521    558   
        }
  522    559   
    }
  523    560   
  524         -
    #[test]
  525         -
    fn test_sign_vanilla_with_headers() {
  526         -
        let settings = SigningSettings::default();
  527         -
        let identity = &Credentials::for_tests().into();
  528         -
        let params = v4::SigningParams {
  529         -
            identity,
  530         -
            region: "us-east-1",
  531         -
            name: "service",
  532         -
            time: parse_date_time("20150830T123600Z").unwrap(),
  533         -
            settings,
  534         -
        }
  535         -
        .into();
  536         -
  537         -
        let original = test::v4::test_request("get-vanilla-query-order-key-case");
  538         -
        let signable = SignableRequest::from(&original);
  539         -
        let out = sign(signable, &params).unwrap();
  540         -
        assert_eq!(
  541         -
            "5557820e7380d585310524bd93d51a08d7757fb5efd7344ee12088f2b0860947",
  542         -
            out.signature
  543         -
        );
  544         -
  545         -
        let mut signed = original.as_http_request();
  546         -
        out.output.apply_to_request_http0x(&mut signed);
  547         -
  548         -
        let expected = test::v4::test_signed_request("get-vanilla-query-order-key-case");
  549         -
        assert_req_eq!(expected, signed);
  550         -
    }
  551         -
         561  +
    // Sigv4A suite tests
  552    562   
    #[cfg(feature = "sigv4a")]
  553         -
    mod sigv4a_tests {
  554         -
        use super::*;
  555         -
        use crate::http_request::canonical_request::{CanonicalRequest, StringToSign};
  556         -
        use crate::http_request::{sign, test, SigningParams};
  557         -
        use crate::sign::v4a;
  558         -
        use p256::ecdsa::signature::{Signature, Verifier};
  559         -
        use p256::ecdsa::{DerSignature, SigningKey};
  560         -
        use pretty_assertions::assert_eq;
  561         -
  562         -
        fn new_v4a_signing_params_from_context(
  563         -
            test_context: &'_ test::v4a::TestContext,
  564         -
            signature_location: SignatureLocation,
  565         -
        ) -> SigningParams<'_> {
  566         -
            let mut params = v4a::SigningParams::from(test_context);
  567         -
            params.settings.signature_location = signature_location;
  568         -
  569         -
            params.into()
  570         -
        }
  571         -
  572         -
        fn run_v4a_test_suite(test_name: &str, signature_location: SignatureLocation) {
  573         -
            let tc = test::v4a::test_context(test_name);
  574         -
            let params = new_v4a_signing_params_from_context(&tc, signature_location);
  575         -
  576         -
            let req = test::v4a::test_request(test_name);
  577         -
            let expected_creq = test::v4a::test_canonical_request(test_name, signature_location);
  578         -
            let signable_req = SignableRequest::from(&req);
  579         -
            let actual_creq = CanonicalRequest::from(&signable_req, &params).unwrap();
         563  +
    mod v4a_suite {
         564  +
        use crate::http_request::test::v4a::run_test_suite_v4a;
  580    565   
  581         -
            assert_eq!(expected_creq, actual_creq.to_string(), "creq didn't match");
  582         -
  583         -
            let expected_string_to_sign =
  584         -
                test::v4a::test_string_to_sign(test_name, signature_location);
  585         -
            let hashed_creq = &v4::sha256_hex_string(actual_creq.to_string().as_bytes());
  586         -
            let actual_string_to_sign = StringToSign::new_v4a(
  587         -
                *params.time(),
  588         -
                params.region_set().unwrap(),
  589         -
                params.name(),
  590         -
                hashed_creq,
  591         -
            )
  592         -
            .to_string();
  593         -
  594         -
            assert_eq!(
  595         -
                expected_string_to_sign, actual_string_to_sign,
  596         -
                "'string to sign' didn't match"
  597         -
            );
  598         -
  599         -
            let out = sign(signable_req, &params).unwrap();
  600         -
            // Sigv4a signatures are non-deterministic, so we can't compare the signature directly.
  601         -
            out.output
  602         -
                .apply_to_request_http0x(&mut req.as_http_request());
  603         -
  604         -
            let creds = params.credentials().unwrap();
  605         -
            let signing_key =
  606         -
                v4a::generate_signing_key(creds.access_key_id(), creds.secret_access_key());
  607         -
            let sig = DerSignature::from_bytes(&hex::decode(out.signature).unwrap()).unwrap();
  608         -
            let sig = sig
  609         -
                .try_into()
  610         -
                .expect("DER-style signatures are always convertible into fixed-size signatures");
  611         -
  612         -
            let signing_key = SigningKey::from_bytes(signing_key.as_ref()).unwrap();
  613         -
            let peer_public_key = signing_key.verifying_key();
  614         -
            let sts = actual_string_to_sign.as_bytes();
  615         -
            peer_public_key.verify(sts, &sig).unwrap();
         566  +
        #[test]
         567  +
        fn test_get_header_key_duplicate() {
         568  +
            run_test_suite_v4a("get-header-key-duplicate")
  616    569   
        }
  617    570   
  618    571   
        #[test]
  619         -
        fn test_get_header_key_duplicate() {
  620         -
            run_v4a_test_suite("get-header-key-duplicate", SignatureLocation::Headers);
         572  +
        #[ignore = "httpparse doesn't support parsing multiline headers since they are deprecated in RFC7230"]
         573  +
        fn test_get_header_value_multiline() {
         574  +
            run_test_suite_v4a("get-header-value-multiline")
  621    575   
        }
  622    576   
  623    577   
        #[test]
  624    578   
        fn test_get_header_value_order() {
  625         -
            run_v4a_test_suite("get-header-value-order", SignatureLocation::Headers);
         579  +
            run_test_suite_v4a("get-header-value-order")
  626    580   
        }
  627    581   
  628    582   
        #[test]
  629    583   
        fn test_get_header_value_trim() {
  630         -
            run_v4a_test_suite("get-header-value-trim", SignatureLocation::Headers);
         584  +
            run_test_suite_v4a("get-header-value-trim");
  631    585   
        }
  632    586   
  633    587   
        #[test]
  634    588   
        fn test_get_relative_normalized() {
  635         -
            run_v4a_test_suite("get-relative-normalized", SignatureLocation::Headers);
         589  +
            run_test_suite_v4a("get-relative-normalized");
  636    590   
        }
  637    591   
  638    592   
        #[test]
  639    593   
        fn test_get_relative_relative_normalized() {
  640         -
            run_v4a_test_suite(
  641         -
                "get-relative-relative-normalized",
  642         -
                SignatureLocation::Headers,
  643         -
            );
         594  +
            run_test_suite_v4a("get-relative-relative-normalized");
  644    595   
        }
  645    596   
  646    597   
        #[test]
  647    598   
        fn test_get_relative_relative_unnormalized() {
  648         -
            run_v4a_test_suite(
  649         -
                "get-relative-relative-unnormalized",
  650         -
                SignatureLocation::Headers,
  651         -
            );
         599  +
            run_test_suite_v4a("get-relative-relative-unnormalized");
  652    600   
        }
  653    601   
  654    602   
        #[test]
  655    603   
        fn test_get_relative_unnormalized() {
  656         -
            run_v4a_test_suite("get-relative-unnormalized", SignatureLocation::Headers);
         604  +
            run_test_suite_v4a("get-relative-unnormalized");
  657    605   
        }
  658    606   
  659    607   
        #[test]
  660    608   
        fn test_get_slash_dot_slash_normalized() {
  661         -
            run_v4a_test_suite("get-slash-dot-slash-normalized", SignatureLocation::Headers);
         609  +
            run_test_suite_v4a("get-slash-dot-slash-normalized");
  662    610   
        }
  663    611   
  664    612   
        #[test]
  665    613   
        fn test_get_slash_dot_slash_unnormalized() {
  666         -
            run_v4a_test_suite(
  667         -
                "get-slash-dot-slash-unnormalized",
  668         -
                SignatureLocation::Headers,
  669         -
            );
         614  +
            run_test_suite_v4a("get-slash-dot-slash-unnormalized");
  670    615   
        }
  671    616   
  672    617   
        #[test]
  673    618   
        fn test_get_slash_normalized() {
  674         -
            run_v4a_test_suite("get-slash-normalized", SignatureLocation::Headers);
         619  +
            run_test_suite_v4a("get-slash-normalized");
  675    620   
        }
  676    621   
  677    622   
        #[test]
  678    623   
        fn test_get_slash_pointless_dot_normalized() {
  679         -
            run_v4a_test_suite(
  680         -
                "get-slash-pointless-dot-normalized",
  681         -
                SignatureLocation::Headers,
  682         -
            );
         624  +
            run_test_suite_v4a("get-slash-pointless-dot-normalized");
  683    625   
        }
  684    626   
  685    627   
        #[test]
  686    628   
        fn test_get_slash_pointless_dot_unnormalized() {
  687         -
            run_v4a_test_suite(
  688         -
                "get-slash-pointless-dot-unnormalized",
  689         -
                SignatureLocation::Headers,
  690         -
            );
         629  +
            run_test_suite_v4a("get-slash-pointless-dot-unnormalized");
  691    630   
        }
  692    631   
  693    632   
        #[test]
  694    633   
        fn test_get_slash_unnormalized() {
  695         -
            run_v4a_test_suite("get-slash-unnormalized", SignatureLocation::Headers);
         634  +
            run_test_suite_v4a("get-slash-unnormalized");
  696    635   
        }
  697    636   
  698    637   
        #[test]
  699    638   
        fn test_get_slashes_normalized() {
  700         -
            run_v4a_test_suite("get-slashes-normalized", SignatureLocation::Headers);
         639  +
            run_test_suite_v4a("get-slashes-normalized");
  701    640   
        }
  702    641   
  703    642   
        #[test]
  704    643   
        fn test_get_slashes_unnormalized() {
  705         -
            run_v4a_test_suite("get-slashes-unnormalized", SignatureLocation::Headers);
         644  +
            run_test_suite_v4a("get-slashes-unnormalized");
         645  +
        }
         646  +
         647  +
        #[test]
         648  +
        #[ignore = "relies on single encode of path segments"]
         649  +
        // rely on single encoding of path segments, i.e. string-to-sign contains %20 for spaces rather than %25%20 as it should.
         650  +
        // skipped until we add control over double_uri_encode in context.json
         651  +
        fn test_get_space_normalized() {
         652  +
            run_test_suite_v4a("get-space-normalized");
         653  +
        }
         654  +
         655  +
        #[test]
         656  +
        #[ignore = "httpparse fails on unencoded spaces in path"]
         657  +
        // the input request has unencoded space ' ' in the path which fails to parse
         658  +
        fn test_get_space_unnormalized() {
         659  +
            run_test_suite_v4a("get-space-unnormalized");
  706    660   
        }
  707    661   
  708    662   
        #[test]
  709    663   
        fn test_get_unreserved() {
  710         -
            run_v4a_test_suite("get-unreserved", SignatureLocation::Headers);
         664  +
            run_test_suite_v4a("get-unreserved");
         665  +
        }
         666  +
         667  +
        #[test]
         668  +
        #[ignore = "httparse fails on invalid uri character"]
         669  +
        // relies on /ሴ canonicalized as /%E1%88%B4 when it should be /%25%E1%25%88%25%B4
         670  +
        fn test_get_utf8() {
         671  +
            run_test_suite_v4a("get-utf8");
  711    672   
        }
  712    673   
  713    674   
        #[test]
  714    675   
        fn test_get_vanilla() {
  715         -
            run_v4a_test_suite("get-vanilla", SignatureLocation::Headers);
         676  +
            run_test_suite_v4a("get-vanilla");
  716    677   
        }
  717    678   
  718    679   
        #[test]
  719    680   
        fn test_get_vanilla_empty_query_key() {
  720         -
            run_v4a_test_suite(
  721         -
                "get-vanilla-empty-query-key",
  722         -
                SignatureLocation::QueryParams,
  723         -
            );
         681  +
            run_test_suite_v4a("get-vanilla-empty-query-key");
  724    682   
        }
  725    683   
  726    684   
        #[test]
  727    685   
        fn test_get_vanilla_query() {
  728         -
            run_v4a_test_suite("get-vanilla-query", SignatureLocation::QueryParams);
         686  +
            run_test_suite_v4a("get-vanilla-query");
         687  +
        }
         688  +
         689  +
        #[test]
         690  +
        fn test_get_vanilla_query_order_encoded() {
         691  +
            run_test_suite_v4a("get-vanilla-query-order-encoded");
  729    692   
        }
  730    693   
  731    694   
        #[test]
  732    695   
        fn test_get_vanilla_query_order_key_case() {
  733         -
            run_v4a_test_suite(
  734         -
                "get-vanilla-query-order-key-case",
  735         -
                SignatureLocation::QueryParams,
  736         -
            );
         696  +
            run_test_suite_v4a("get-vanilla-query-order-key-case");
  737    697   
        }
  738    698   
  739    699   
        #[test]
  740    700   
        fn test_get_vanilla_query_unreserved() {
  741         -
            run_v4a_test_suite(
  742         -
                "get-vanilla-query-unreserved",
  743         -
                SignatureLocation::QueryParams,
  744         -
            );
         701  +
            run_test_suite_v4a("get-vanilla-query-unreserved");
         702  +
        }
         703  +
         704  +
        #[test]
         705  +
        #[ignore = "httparse fails on invalid uri character"]
         706  +
        // relies on /ሴ canonicalized as /%E1%88%B4 when it should be /%25%E1%25%88%25%B4
         707  +
        fn test_get_vanilla_utf8_query() {
         708  +
            run_test_suite_v4a("get-vanilla-utf8-query");
  745    709   
        }
  746    710   
  747    711   
        #[test]
  748    712   
        fn test_get_vanilla_with_session_token() {
  749         -
            run_v4a_test_suite("get-vanilla-with-session-token", SignatureLocation::Headers);
         713  +
            run_test_suite_v4a("get-vanilla-with-session-token")
  750    714   
        }
  751    715   
  752    716   
        #[test]
  753    717   
        fn test_post_header_key_case() {
  754         -
            run_v4a_test_suite("post-header-key-case", SignatureLocation::Headers);
         718  +
            run_test_suite_v4a("post-header-key-case");
  755    719   
        }
  756    720   
  757    721   
        #[test]
  758    722   
        fn test_post_header_key_sort() {
  759         -
            run_v4a_test_suite("post-header-key-sort", SignatureLocation::Headers);
         723  +
            run_test_suite_v4a("post-header-key-sort");
  760    724   
        }
  761    725   
  762    726   
        #[test]
  763    727   
        fn test_post_header_value_case() {
  764         -
            run_v4a_test_suite("post-header-value-case", SignatureLocation::Headers);
         728  +
            run_test_suite_v4a("post-header-value-case");
  765    729   
        }
  766    730   
  767    731   
        #[test]
  768    732   
        fn test_post_sts_header_after() {
  769         -
            run_v4a_test_suite("post-sts-header-after", SignatureLocation::Headers);
         733  +
            run_test_suite_v4a("post-sts-header-after");
  770    734   
        }
  771    735   
  772    736   
        #[test]
  773    737   
        fn test_post_sts_header_before() {
  774         -
            run_v4a_test_suite("post-sts-header-before", SignatureLocation::Headers);
         738  +
            run_test_suite_v4a("post-sts-header-before");
  775    739   
        }
  776    740   
  777    741   
        #[test]
  778    742   
        fn test_post_vanilla() {
  779         -
            run_v4a_test_suite("post-vanilla", SignatureLocation::Headers);
         743  +
            run_test_suite_v4a("post-vanilla");
  780    744   
        }
  781    745   
  782    746   
        #[test]
  783    747   
        fn test_post_vanilla_empty_query_value() {
  784         -
            run_v4a_test_suite(
  785         -
                "post-vanilla-empty-query-value",
  786         -
                SignatureLocation::QueryParams,
  787         -
            );
         748  +
            run_test_suite_v4a("post-vanilla-empty-query-value");
  788    749   
        }
  789    750   
  790    751   
        #[test]
  791    752   
        fn test_post_vanilla_query() {
  792         -
            run_v4a_test_suite("post-vanilla-query", SignatureLocation::QueryParams);
         753  +
            run_test_suite_v4a("post-vanilla-query");
  793    754   
        }
  794    755   
  795    756   
        #[test]
  796    757   
        fn test_post_x_www_form_urlencoded() {
  797         -
            run_v4a_test_suite("post-x-www-form-urlencoded", SignatureLocation::Headers);
         758  +
            run_test_suite_v4a("post-x-www-form-urlencoded");
  798    759   
        }
  799    760   
  800    761   
        #[test]
  801    762   
        fn test_post_x_www_form_urlencoded_parameters() {
  802         -
            run_v4a_test_suite(
  803         -
                "post-x-www-form-urlencoded-parameters",
  804         -
                SignatureLocation::QueryParams,
  805         -
            );
         763  +
            run_test_suite_v4a("post-x-www-form-urlencoded-parameters");
  806    764   
        }
  807    765   
    }
  808    766   
  809    767   
    #[test]
  810    768   
    fn test_sign_url_escape() {
  811         -
        let test = "double-encode-path";
         769  +
        let test = SigningSuiteTest::v4("double-encode-path");
  812    770   
        let settings = SigningSettings::default();
  813    771   
        let identity = &Credentials::for_tests().into();
  814    772   
        let params = v4::SigningParams {
  815    773   
            identity,
  816    774   
            region: "us-east-1",
  817    775   
            name: "service",
  818    776   
            time: parse_date_time("20150830T123600Z").unwrap(),
  819    777   
            settings,
  820    778   
        }
  821    779   
        .into();
  822    780   
  823         -
        let original = test::v4::test_request(test);
         781  +
        let original = test.request();
  824    782   
        let signable = SignableRequest::from(&original);
  825    783   
        let out = sign(signable, &params).unwrap();
  826    784   
        assert_eq!(
  827    785   
            "57d157672191bac40bae387e48bbe14b15303c001fdbb01f4abf295dccb09705",
  828    786   
            out.signature
  829    787   
        );
  830    788   
  831    789   
        let mut signed = original.as_http_request();
  832    790   
        out.output.apply_to_request_http0x(&mut signed);
  833    791   
  834         -
        let expected = test::v4::test_signed_request(test);
  835         -
        assert_req_eq!(expected, signed);
  836         -
    }
  837         -
  838         -
    #[test]
  839         -
    fn test_sign_vanilla_with_query_params() {
  840         -
        let settings = SigningSettings {
  841         -
            signature_location: SignatureLocation::QueryParams,
  842         -
            expires_in: Some(Duration::from_secs(35)),
  843         -
            ..Default::default()
  844         -
        };
  845         -
        let identity = &Credentials::for_tests().into();
  846         -
        let params = v4::SigningParams {
  847         -
            identity,
  848         -
            region: "us-east-1",
  849         -
            name: "service",
  850         -
            time: parse_date_time("20150830T123600Z").unwrap(),
  851         -
            settings,
  852         -
        }
  853         -
        .into();
  854         -
  855         -
        let original = test::v4::test_request("get-vanilla-query-order-key-case");
  856         -
        let signable = SignableRequest::from(&original);
  857         -
        let out = sign(signable, &params).unwrap();
  858         -
        assert_eq!(
  859         -
            "ecce208e4b4f7d7e3a4cc22ced6acc2ad1d170ee8ba87d7165f6fa4b9aff09ab",
  860         -
            out.signature
  861         -
        );
  862         -
  863         -
        let mut signed = original.as_http_request();
  864         -
        out.output.apply_to_request_http0x(&mut signed);
  865         -
  866         -
        let expected =
  867         -
            test::v4::test_signed_request_query_params("get-vanilla-query-order-key-case");
         792  +
        let expected = test.signed_request(SignatureLocation::Headers);
  868    793   
        assert_req_eq!(expected, signed);
  869    794   
    }
  870    795   
  871    796   
    #[test]
  872    797   
    fn test_sign_headers_utf8() {
  873    798   
        let settings = SigningSettings::default();
  874    799   
        let identity = &Credentials::for_tests().into();
  875    800   
        let params = v4::SigningParams {
  876    801   
            identity,
  877    802   
            region: "us-east-1",
  878    803   
            name: "service",
  879    804   
            time: parse_date_time("20150830T123600Z").unwrap(),
  880    805   
            settings,
  881    806   
        }
  882    807   
        .into();
  883    808   
  884    809   
        let original = http0::Request::builder()
  885    810   
            .uri("https://some-endpoint.some-region.amazonaws.com")
  886    811   
            .header("some-header", HeaderValue::from_str("テスト").unwrap())
  887    812   
            .body("")
  888    813   
            .unwrap()
  889    814   
            .into();
  890    815   
        let signable = SignableRequest::from(&original);
  891    816   
        let out = sign(signable, &params).unwrap();
  892    817   
        assert_eq!(
  893    818   
            "55e16b31f9bde5fd04f9d3b780dd2b5e5f11a5219001f91a8ca9ec83eaf1618f",
  894    819   
            out.signature
  895    820   
        );
  896    821   
  897    822   
        let mut signed = original.as_http_request();
  898    823   
@@ -1138,31 +1028,236 @@ mod tests {
  899    824   
        let mut request = http::Request::builder()
  900    825   
            .uri("https://some-endpoint.some-region.amazonaws.com/some/path")
  901    826   
            .body("")
  902    827   
            .unwrap();
  903    828   
  904    829   
        instructions.apply_to_request_http1x(&mut request);
  905    830   
  906    831   
        assert_eq!(
  907    832   
            "/some/path?some-param=f%26o%3Fo&some-other-param%3F=bar",
  908    833   
            request.uri().path_and_query().unwrap().to_string()
  909    834   
        );
  910    835   
    }
  911    836   
  912    837   
    #[test]
  913    838   
    fn test_debug_signable_body() {
  914    839   
        let sut = SignableBody::Bytes(b"hello signable body");
  915    840   
        assert_eq!(
  916    841   
            "Bytes(\"** REDACTED **. To print 19 bytes of raw data, set environment variable `LOG_SIGNABLE_BODY=true`\")",
  917    842   
            format!("{sut:?}")
  918    843   
        );
  919    844   
  920    845   
        let sut = SignableBody::UnsignedPayload;
  921    846   
        assert_eq!("UnsignedPayload", format!("{sut:?}"));
  922    847   
  923    848   
        let sut = SignableBody::Precomputed("precomputed".to_owned());
  924    849   
        assert_eq!("Precomputed(\"precomputed\")", format!("{sut:?}"));
  925    850   
  926    851   
        let sut = SignableBody::StreamingUnsignedPayloadTrailer;
  927    852   
        assert_eq!("StreamingUnsignedPayloadTrailer", format!("{sut:?}"));
  928    853   
    }
         854  +
         855  +
    // v4 test suite
         856  +
    mod v4_suite {
         857  +
        use crate::http_request::test::run_test_suite_v4;
         858  +
         859  +
        #[test]
         860  +
        fn test_get_header_key_duplicate() {
         861  +
            run_test_suite_v4("get-header-key-duplicate");
         862  +
        }
         863  +
         864  +
        #[test]
         865  +
        #[ignore = "httpparse doesn't support parsing multiline headers since they are deprecated in RFC7230"]
         866  +
        fn test_get_header_value_multiline() {
         867  +
            run_test_suite_v4("get-header-value-multiline");
         868  +
        }
         869  +
         870  +
        #[test]
         871  +
        fn test_get_header_value_order() {
         872  +
            run_test_suite_v4("get-header-value-order");
         873  +
        }
         874  +
         875  +
        #[test]
         876  +
        fn test_get_header_value_trim() {
         877  +
            run_test_suite_v4("get-header-value-trim");
         878  +
        }
         879  +
         880  +
        #[test]
         881  +
        fn test_get_relative_normalized() {
         882  +
            run_test_suite_v4("get-relative-normalized");
         883  +
        }
         884  +
         885  +
        #[test]
         886  +
        fn test_get_relative_relative_normalized() {
         887  +
            run_test_suite_v4("get-relative-relative-normalized");
         888  +
        }
         889  +
         890  +
        #[test]
         891  +
        fn test_get_relative_relative_unnormalized() {
         892  +
            run_test_suite_v4("get-relative-relative-unnormalized");
         893  +
        }
         894  +
         895  +
        #[test]
         896  +
        fn test_get_relative_unnormalized() {
         897  +
            run_test_suite_v4("get-relative-unnormalized");
         898  +
        }
         899  +
         900  +
        #[test]
         901  +
        fn test_get_slash_dot_slash_normalized() {
         902  +
            run_test_suite_v4("get-slash-dot-slash-normalized");
         903  +
        }
         904  +
         905  +
        #[test]
         906  +
        fn test_get_slash_dot_slash_unnormalized() {
         907  +
            run_test_suite_v4("get-slash-dot-slash-unnormalized");
         908  +
        }
         909  +
         910  +
        #[test]
         911  +
        fn test_get_slash_normalized() {
         912  +
            run_test_suite_v4("get-slash-normalized");
         913  +
        }
         914  +
         915  +
        #[test]
         916  +
        fn test_get_slash_pointless_dot_normalized() {
         917  +
            run_test_suite_v4("get-slash-pointless-dot-normalized");
         918  +
        }
         919  +
         920  +
        #[test]
         921  +
        fn test_get_slash_pointless_dot_unnormalized() {
         922  +
            run_test_suite_v4("get-slash-pointless-dot-unnormalized");
         923  +
        }
         924  +
         925  +
        #[test]
         926  +
        fn test_get_slash_unnormalized() {
         927  +
            run_test_suite_v4("get-slash-unnormalized");
         928  +
        }
         929  +
         930  +
        #[test]
         931  +
        fn test_get_slashes_normalized() {
         932  +
            run_test_suite_v4("get-slashes-normalized");
         933  +
        }
         934  +
         935  +
        #[test]
         936  +
        fn test_get_slashes_unnormalized() {
         937  +
            run_test_suite_v4("get-slashes-unnormalized");
         938  +
        }
         939  +
         940  +
        #[test]
         941  +
        #[ignore = "relies on single encode of path segments"]
         942  +
        // rely on single encoding of path segments, i.e. string-to-sign contains %20 for spaces rather than %25%20 as it should.
         943  +
        // skipped until we add control over double_uri_encode in context.json
         944  +
        fn test_get_space_normalized() {
         945  +
            run_test_suite_v4("get-space-normalized");
         946  +
        }
         947  +
         948  +
        #[test]
         949  +
        #[ignore = "httpparse fails on unencoded spaces in path"]
         950  +
        // the input request has unencoded space ' ' in the path which fails to parse
         951  +
        fn test_get_space_unnormalized() {
         952  +
            run_test_suite_v4("get-space-unnormalized");
         953  +
        }
         954  +
         955  +
        #[test]
         956  +
        fn test_get_unreserved() {
         957  +
            run_test_suite_v4("get-unreserved");
         958  +
        }
         959  +
         960  +
        #[test]
         961  +
        #[ignore = "httparse fails on invalid uri character"]
         962  +
        // relies on /ሴ canonicalized as /%E1%88%B4 when it should be /%25%E1%25%88%25%B4
         963  +
        fn test_get_utf8() {
         964  +
            run_test_suite_v4("get-utf8");
         965  +
        }
         966  +
         967  +
        #[test]
         968  +
        fn test_get_vanilla() {
         969  +
            run_test_suite_v4("get-vanilla");
         970  +
        }
         971  +
         972  +
        #[test]
         973  +
        fn test_get_vanilla_empty_query_key() {
         974  +
            run_test_suite_v4("get-vanilla-empty-query-key");
         975  +
        }
         976  +
         977  +
        #[test]
         978  +
        fn test_get_vanilla_query() {
         979  +
            run_test_suite_v4("get-vanilla-query");
         980  +
        }
         981  +
         982  +
        #[test]
         983  +
        fn test_get_vanilla_query_order_encoded() {
         984  +
            run_test_suite_v4("get-vanilla-query-order-encoded");
         985  +
        }
         986  +
         987  +
        #[test]
         988  +
        fn test_get_vanilla_query_order_key_case() {
         989  +
            run_test_suite_v4("get-vanilla-query-order-key-case");
         990  +
        }
         991  +
         992  +
        #[test]
         993  +
        fn test_get_vanilla_query_unreserved() {
         994  +
            run_test_suite_v4("get-vanilla-query-unreserved");
         995  +
        }
         996  +
         997  +
        #[test]
         998  +
        #[ignore = "httparse fails on invalid uri character"]
         999  +
        // relies on /ሴ canonicalized as /%E1%88%B4 when it should be /%25%E1%25%88%25%B4
        1000  +
        fn test_get_vanilla_utf8_query() {
        1001  +
            run_test_suite_v4("get-vanilla-utf8-query");
        1002  +
        }
        1003  +
        1004  +
        #[test]
        1005  +
        fn test_get_vanilla_with_session_token() {
        1006  +
            run_test_suite_v4("get-vanilla-with-session-token");
        1007  +
        }
        1008  +
        1009  +
        #[test]
        1010  +
        fn test_post_header_key_case() {
        1011  +
            run_test_suite_v4("post-header-key-case");
        1012  +
        }
        1013  +
        1014  +
        #[test]
        1015  +
        fn test_post_header_key_sort() {
        1016  +
            run_test_suite_v4("post-header-key-sort");
        1017  +
        }
        1018  +
        1019  +
        #[test]
        1020  +
        fn test_post_header_value_case() {
        1021  +
            run_test_suite_v4("post-header-value-case");
        1022  +
        }
        1023  +
        1024  +
        #[test]
        1025  +
        fn test_post_sts_header_after() {
        1026  +
            run_test_suite_v4("post-sts-header-after");
        1027  +
        }
        1028  +
        1029  +
        #[test]
        1030  +
        fn test_post_sts_header_before() {
        1031  +
            run_test_suite_v4("post-sts-header-before");
        1032  +
        }
        1033  +
        1034  +
        #[test]
        1035  +
        fn test_post_vanilla() {
        1036  +
            run_test_suite_v4("post-vanilla");
        1037  +
        }
        1038  +
        1039  +
        #[test]
        1040  +
        fn test_post_vanilla_empty_query_value() {
        1041  +
            run_test_suite_v4("post-vanilla-empty-query-value");
        1042  +
        }
        1043  +
        1044  +
        #[test]
        1045  +
        fn test_post_vanilla_query() {
        1046  +
            run_test_suite_v4("post-vanilla-query");
        1047  +
        }
        1048  +
        1049  +
        #[test]
        1050  +
        fn test_post_x_www_form_urlencoded() {
        1051  +
            run_test_suite_v4("post-x-www-form-urlencoded");
        1052  +
        }
        1053  +
        1054  +
        #[test]
        1055  +
        fn test_post_x_www_form_urlencoded_parameters() {
        1056  +
            run_test_suite_v4("post-x-www-form-urlencoded-parameters");
        1057  +
        }
        1058  +
    }
  929   1059   
}
  930   1060   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/test.rs b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/test.rs
  931   1061   
index be6c496..86eec20 100644
  932         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/test.rs
        1062  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/http_request/test.rs
  933   1063   
@@ -1,242 +1,453 @@
  934   1064   
/*
  935   1065   
 * Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved.
  936   1066   
 * SPDX-License-Identifier: Apache-2.0
  937   1067   
 */
  938   1068   
  939   1069   
//! Functions shared between the tests of several modules.
  940   1070   
  941         -
use crate::http_request::{SignableBody, SignableRequest};
        1071  +
use crate::http_request::canonical_request::{CanonicalRequest, StringToSign};
        1072  +
use crate::http_request::{
        1073  +
    PayloadChecksumKind, SessionTokenMode, SignableBody, SignableRequest, SignatureLocation,
        1074  +
    SigningSettings,
        1075  +
};
        1076  +
use aws_credential_types::Credentials;
        1077  +
use aws_smithy_runtime_api::client::identity::Identity;
  942   1078   
use http0::{Method, Uri};
        1079  +
use std::borrow::Cow;
  943   1080   
use std::error::Error as StdError;
        1081  +
use std::time::{Duration, SystemTime};
        1082  +
use time::format_description::well_known::Rfc3339;
        1083  +
use time::OffsetDateTime;
        1084  +
        1085  +
/// Common test suite collection
        1086  +
#[derive(Debug, Clone, Copy, Eq, PartialEq)]
        1087  +
enum Collection {
        1088  +
    V4,
        1089  +
    V4A,
        1090  +
}
  944   1091   
  945         -
pub(crate) mod v4 {
  946         -
    use super::*;
        1092  +
/// A test from the common CRT test suite
        1093  +
#[derive(Debug, Clone)]
        1094  +
pub(crate) struct SigningSuiteTest {
        1095  +
    test_name: &'static str,
        1096  +
    collection: Collection,
        1097  +
}
  947   1098   
  948         -
    fn path(name: &str, ext: &str) -> String {
  949         -
        format!("aws-sig-v4-test-suite/{}/{}.{}", name, name, ext)
        1099  +
impl SigningSuiteTest {
        1100  +
    /// Create a new test from the V4 test suite
        1101  +
    pub(crate) fn v4(test_name: &'static str) -> Self {
        1102  +
        Self {
        1103  +
            test_name,
        1104  +
            collection: Collection::V4,
  950   1105   
        }
  951         -
  952         -
    pub(crate) fn test_canonical_request(name: &str) -> String {
  953         -
        // Tests fail if there's a trailing newline in the file, and pre-commit requires trailing newlines
  954         -
        read(&path(name, "creq")).trim().to_string()
  955   1106   
    }
  956   1107   
  957         -
    pub(crate) fn test_sts(name: &str) -> String {
  958         -
        read(&path(name, "sts"))
        1108  +
    /// Create a new test from the V4a test suite
        1109  +
    pub(crate) fn v4a(test_name: &'static str) -> Self {
        1110  +
        Self {
        1111  +
            test_name,
        1112  +
            collection: Collection::V4A,
  959   1113   
        }
  960         -
  961         -
    pub(crate) fn test_request(name: &str) -> TestRequest {
  962         -
        test_parsed_request(name, "req")
  963   1114   
    }
  964   1115   
  965         -
    pub(crate) fn test_signed_request(name: &str) -> TestRequest {
  966         -
        test_parsed_request(name, "sreq")
        1116  +
    /// Get the path to a file in this test suite directory
        1117  +
    fn path(&self, filename: &str) -> String {
        1118  +
        let dir = match self.collection {
        1119  +
            Collection::V4 => "v4",
        1120  +
            Collection::V4A => "v4a",
        1121  +
        };
        1122  +
        format!("aws-signing-test-suite/{dir}/{}/{filename}", self.test_name)
  967   1123   
    }
  968   1124   
  969         -
    pub(crate) fn test_signed_request_query_params(name: &str) -> TestRequest {
  970         -
        test_parsed_request(name, "qpsreq")
        1125  +
    /// Get the HTTP request for the test
        1126  +
    pub(crate) fn request(&self) -> TestRequest {
        1127  +
        test_parsed_request(&self.path("request.txt"))
  971   1128   
    }
  972   1129   
  973         -
    fn test_parsed_request(name: &str, ext: &str) -> TestRequest {
  974         -
        let path = path(name, ext);
  975         -
        match parse_request(read(&path).as_bytes()) {
  976         -
            Ok(parsed) => parsed,
  977         -
            Err(err) => panic!("Failed to parse {}: {}", path, err),
        1130  +
    /// Get the signed HTTP request for the test
        1131  +
    pub(crate) fn signed_request(&self, signature_location: SignatureLocation) -> TestRequest {
        1132  +
        match signature_location {
        1133  +
            SignatureLocation::QueryParams => {
        1134  +
                test_parsed_request(&self.path("query-signed-request.txt"))
  978   1135   
            }
        1136  +
            SignatureLocation::Headers => {
        1137  +
                test_parsed_request(&self.path("header-signed-request.txt"))
  979   1138   
            }
  980         -
  981         -
    #[test]
  982         -
    fn test_parse() {
  983         -
        test_request("post-header-key-case");
  984   1139   
        }
  985         -
  986         -
    #[test]
  987         -
    fn test_read_query_params() {
  988         -
        test_request("get-vanilla-query-order-key-case");
  989   1140   
    }
  990         -
}
  991         -
  992         -
#[cfg(feature = "sigv4a")]
  993         -
pub(crate) mod v4a {
  994         -
    use super::*;
  995         -
    use crate::http_request::{
  996         -
        PayloadChecksumKind, SessionTokenMode, SignatureLocation, SigningSettings,
  997         -
    };
  998         -
    use aws_credential_types::Credentials;
  999         -
    use aws_smithy_runtime_api::client::identity::Identity;
 1000         -
    use serde_derive::Deserialize;
 1001         -
    use std::time::{Duration, SystemTime};
 1002         -
    use time::format_description::well_known::Rfc3339;
 1003         -
    use time::OffsetDateTime;
 1004   1141   
 1005         -
    fn path(test_name: &str, definition_name: &str) -> String {
 1006         -
        format!("aws-sig-v4a-test-suite/{test_name}/{definition_name}.txt")
        1142  +
    /// Get the canonical request for the test
        1143  +
    pub(crate) fn canonical_request(&self, signature_location: SignatureLocation) -> String {
        1144  +
        match signature_location {
        1145  +
            SignatureLocation::QueryParams => read(&self.path("query-canonical-request.txt")),
        1146  +
            SignatureLocation::Headers => read(&self.path("header-canonical-request.txt")),
 1007   1147   
        }
 1008         -
 1009         -
    pub(crate) fn test_request(name: &str) -> TestRequest {
 1010         -
        test_parsed_request(&path(name, "request"))
 1011   1148   
    }
 1012   1149   
 1013         -
    pub(crate) fn test_canonical_request(
 1014         -
        name: &str,
 1015         -
        signature_location: SignatureLocation,
 1016         -
    ) -> String {
        1150  +
    /// Get the string to sign for the test
        1151  +
    pub(crate) fn string_to_sign(&self, signature_location: SignatureLocation) -> String {
 1017   1152   
        match signature_location {
 1018         -
            SignatureLocation::QueryParams => read(&path(name, "query-canonical-request")),
 1019         -
            SignatureLocation::Headers => read(&path(name, "header-canonical-request")),
        1153  +
            SignatureLocation::QueryParams => read(&self.path("query-string-to-sign.txt")),
        1154  +
            SignatureLocation::Headers => read(&self.path("header-string-to-sign.txt")),
 1020   1155   
        }
 1021   1156   
    }
 1022   1157   
 1023         -
    pub(crate) fn test_string_to_sign(name: &str, signature_location: SignatureLocation) -> String {
        1158  +
    /// Get the signature for the test
        1159  +
    pub(crate) fn signature(&self, signature_location: SignatureLocation) -> String {
 1024   1160   
        match signature_location {
 1025         -
            SignatureLocation::QueryParams => read(&path(name, "query-string-to-sign")),
 1026         -
            SignatureLocation::Headers => read(&path(name, "header-string-to-sign")),
        1161  +
            SignatureLocation::QueryParams => read(&self.path("query-signature.txt")),
        1162  +
            SignatureLocation::Headers => read(&self.path("header-signature.txt")),
        1163  +
        }
 1027   1164   
    }
        1165  +
        1166  +
    /// Get the test context for the test
        1167  +
    pub(crate) fn context(&self) -> TestContext {
        1168  +
        let context = read(&self.path("context.json"));
        1169  +
        let tc_builder: TestContextBuilder = serde_json::from_str(&context).unwrap();
        1170  +
        tc_builder.build()
 1028   1171   
    }
        1172  +
}
 1029   1173   
 1030         -
    fn test_parsed_request(path: &str) -> TestRequest {
        1174  +
fn test_parsed_request(path: &str) -> TestRequest {
 1031   1175   
    match parse_request(read(path).as_bytes()) {
 1032   1176   
        Ok(parsed) => parsed,
 1033   1177   
        Err(err) => panic!("Failed to parse {}: {}", path, err),
 1034   1178   
    }
 1035         -
    }
        1179  +
}
 1036   1180   
 1037         -
    pub(crate) fn test_context(test_name: &str) -> TestContext {
 1038         -
        let path = format!("aws-sig-v4a-test-suite/{test_name}/context.json");
 1039         -
        let context = read(&path);
 1040         -
        let tc_builder: TestContextBuilder = serde_json::from_str(&context).unwrap();
 1041         -
        tc_builder.build()
 1042         -
    }
        1181  +
fn new_v4_signing_params_from_context(
        1182  +
    test_context: &'_ TestContext,
        1183  +
    signature_location: SignatureLocation,
        1184  +
) -> crate::http_request::SigningParams<'_> {
        1185  +
    let mut params = crate::sign::v4::SigningParams::from(test_context);
        1186  +
    params.settings.signature_location = signature_location;
        1187  +
    params.into()
        1188  +
}
        1189  +
        1190  +
/// Run the given test from the v4 suite for both header and query
        1191  +
/// signature locations
        1192  +
pub(crate) fn run_test_suite_v4(test_name: &'static str) {
        1193  +
    run_v4_test(test_name, SignatureLocation::Headers);
        1194  +
    run_v4_test(test_name, SignatureLocation::QueryParams);
        1195  +
}
        1196  +
        1197  +
fn assert_uri_eq(expected: &Uri, actual: &Uri) {
        1198  +
    assert_eq!(expected.scheme(), actual.scheme());
        1199  +
    assert_eq!(expected.authority(), actual.authority());
        1200  +
    assert_eq!(expected.path(), actual.path());
        1201  +
        1202  +
    // query params may be out of order
        1203  +
    let mut expected_params: Vec<(Cow<'_, str>, Cow<'_, str>)> =
        1204  +
        form_urlencoded::parse(expected.query().unwrap_or_default().as_bytes()).collect();
        1205  +
    expected_params.sort();
        1206  +
        1207  +
    let mut actual_params: Vec<(Cow<'_, str>, Cow<'_, str>)> =
        1208  +
        form_urlencoded::parse(actual.query().unwrap_or_default().as_bytes()).collect();
        1209  +
    actual_params.sort();
        1210  +
        1211  +
    assert_eq!(expected_params, actual_params);
        1212  +
}
 1043   1213   
 1044         -
    pub(crate) struct TestContext {
        1214  +
fn assert_requests_eq(expected: TestRequest, actual: http0::Request<&str>) {
        1215  +
    let expected = expected.as_http_request();
        1216  +
    let actual = actual;
        1217  +
    assert_eq!(expected.method(), actual.method());
        1218  +
    assert_eq!(
        1219  +
        expected.headers().len(),
        1220  +
        actual.headers().len(),
        1221  +
        "extra or missing headers"
        1222  +
    );
        1223  +
    assert_eq!(expected.headers(), actual.headers(), "headers mismatch");
        1224  +
    assert_uri_eq(expected.uri(), actual.uri());
        1225  +
    assert_eq!(*expected.body(), *actual.body(), "body mismatch");
        1226  +
}
        1227  +
        1228  +
/// Run the given test from the v4 suite for the given signature location
        1229  +
pub(crate) fn run_v4_test(test_name: &'static str, signature_location: SignatureLocation) {
        1230  +
    let test = SigningSuiteTest::v4(test_name);
        1231  +
    let tc = test.context();
        1232  +
    let params = new_v4_signing_params_from_context(&tc, signature_location);
        1233  +
        1234  +
    let req = test.request();
        1235  +
    let expected_creq = test.canonical_request(signature_location);
        1236  +
    let signable_req = SignableRequest::from(&req);
        1237  +
    let actual_creq = CanonicalRequest::from(&signable_req, &params).unwrap();
        1238  +
        1239  +
    // check canonical request
        1240  +
    assert_eq!(
        1241  +
        expected_creq,
        1242  +
        actual_creq.to_string(),
        1243  +
        "canonical request didn't match (signature location: {signature_location:?})"
        1244  +
    );
        1245  +
        1246  +
    let expected_string_to_sign = test.string_to_sign(signature_location);
        1247  +
    let hashed_creq = &crate::sign::v4::sha256_hex_string(actual_creq.to_string().as_bytes());
        1248  +
    let actual_string_to_sign = StringToSign::new_v4(
        1249  +
        *params.time(),
        1250  +
        params.region().unwrap(),
        1251  +
        params.name(),
        1252  +
        hashed_creq,
        1253  +
    )
        1254  +
    .to_string();
        1255  +
        1256  +
    // check string to sign
        1257  +
    assert_eq!(
        1258  +
        expected_string_to_sign, actual_string_to_sign,
        1259  +
        "'string to sign' didn't match (signature location: {signature_location:?})"
        1260  +
    );
        1261  +
        1262  +
    let out = crate::http_request::sign(signable_req, &params).unwrap();
        1263  +
    let mut signed = req.as_http_request();
        1264  +
    out.output.apply_to_request_http0x(&mut signed);
        1265  +
        1266  +
    // check signature
        1267  +
    assert_eq!(
        1268  +
        test.signature(signature_location),
        1269  +
        out.signature,
        1270  +
        "signature didn't match (signature location: {signature_location:?})"
        1271  +
    );
        1272  +
        1273  +
    let expected = test.signed_request(signature_location);
        1274  +
    assert_requests_eq(expected, signed);
        1275  +
}
        1276  +
        1277  +
/// Test suite context.json
        1278  +
pub(crate) struct TestContext {
 1045   1279   
    pub(crate) identity: Identity,
 1046   1280   
    pub(crate) expiration_in_seconds: u64,
 1047   1281   
    pub(crate) normalize: bool,
 1048   1282   
    pub(crate) region: String,
 1049   1283   
    pub(crate) service: String,
 1050   1284   
    pub(crate) timestamp: String,
 1051   1285   
    pub(crate) omit_session_token: bool,
 1052   1286   
    pub(crate) sign_body: bool,
 1053         -
    }
 1054         -
 1055         -
    impl<'a> From<&'a TestContext> for crate::sign::v4a::SigningParams<'a, SigningSettings> {
 1056         -
        fn from(tc: &'a TestContext) -> Self {
 1057         -
            crate::sign::v4a::SigningParams {
 1058         -
                identity: &tc.identity,
 1059         -
                region_set: &tc.region,
 1060         -
                name: &tc.service,
 1061         -
                time: OffsetDateTime::parse(&tc.timestamp, &Rfc3339)
 1062         -
                    .unwrap()
 1063         -
                    .into(),
 1064         -
                settings: SigningSettings {
 1065         -
                    // payload_checksum_kind: PayloadChecksumKind::XAmzSha256,
 1066         -
                    expires_in: Some(Duration::from_secs(tc.expiration_in_seconds)),
 1067         -
                    uri_path_normalization_mode: tc.normalize.into(),
 1068         -
                    session_token_mode: if tc.omit_session_token {
 1069         -
                        SessionTokenMode::Exclude
 1070         -
                    } else {
 1071         -
                        SessionTokenMode::Include
 1072         -
                    },
 1073         -
                    payload_checksum_kind: if tc.sign_body {
 1074         -
                        PayloadChecksumKind::XAmzSha256
 1075         -
                    } else {
 1076         -
                        PayloadChecksumKind::NoHeader
 1077         -
                    },
 1078         -
                    ..Default::default()
 1079         -
                },
 1080         -
            }
 1081         -
        }
 1082         -
    }
        1287  +
}
 1083   1288   
 1084         -
    // Serde has limitations requiring this odd workaround.
 1085         -
    // See https://github.com/serde-rs/serde/issues/368 for more info.
 1086         -
    fn return_true() -> bool {
        1289  +
// Serde has limitations requiring this odd workaround.
        1290  +
// See https://github.com/serde-rs/serde/issues/368 for more info.
        1291  +
fn return_true() -> bool {
 1087   1292   
    true
 1088         -
    }
        1293  +
}
 1089   1294   
 1090         -
    #[derive(Deserialize)]
 1091         -
    pub(crate) struct TestContextBuilder {
        1295  +
#[derive(serde_derive::Deserialize)]
        1296  +
pub(crate) struct TestContextBuilder {
 1092   1297   
    credentials: TestContextCreds,
 1093   1298   
    expiration_in_seconds: u64,
 1094   1299   
    normalize: bool,
 1095   1300   
    region: String,
 1096   1301   
    service: String,
 1097   1302   
    timestamp: String,
 1098   1303   
    #[serde(default)]
 1099   1304   
    omit_session_token: bool,
 1100   1305   
    #[serde(default = "return_true")]
 1101   1306   
    sign_body: bool,
 1102         -
    }
        1307  +
}
 1103   1308   
 1104         -
    impl TestContextBuilder {
        1309  +
impl TestContextBuilder {
 1105   1310   
    pub(crate) fn build(self) -> TestContext {
 1106   1311   
        let identity = Identity::new(
 1107   1312   
            Credentials::from_keys(
 1108   1313   
                &self.credentials.access_key_id,
 1109   1314   
                &self.credentials.secret_access_key,
 1110   1315   
                self.credentials.token.clone(),
 1111   1316   
            ),
 1112   1317   
            Some(SystemTime::UNIX_EPOCH + Duration::from_secs(self.expiration_in_seconds)),
 1113   1318   
        );
 1114   1319   
 1115   1320   
        TestContext {
 1116   1321   
            identity,
 1117   1322   
            expiration_in_seconds: self.expiration_in_seconds,
 1118   1323   
            normalize: self.normalize,
 1119   1324   
            region: self.region,
 1120   1325   
            service: self.service,
 1121   1326   
            timestamp: self.timestamp,
 1122   1327   
            omit_session_token: self.omit_session_token,
 1123   1328   
            sign_body: self.sign_body,
 1124   1329   
        }
 1125   1330   
    }
 1126         -
    }
        1331  +
}
 1127   1332   
 1128         -
    #[derive(Deserialize)]
 1129         -
    pub(crate) struct TestContextCreds {
        1333  +
#[derive(serde_derive::Deserialize)]
        1334  +
pub(crate) struct TestContextCreds {
 1130   1335   
    access_key_id: String,
 1131   1336   
    secret_access_key: String,
 1132   1337   
    token: Option<String>,
        1338  +
}
        1339  +
        1340  +
impl<'a> From<&'a TestContext> for crate::sign::v4::SigningParams<'a, SigningSettings> {
        1341  +
    fn from(tc: &'a TestContext) -> Self {
        1342  +
        crate::sign::v4::SigningParams {
        1343  +
            identity: &tc.identity,
        1344  +
            region: &tc.region,
        1345  +
            name: &tc.service,
        1346  +
            time: OffsetDateTime::parse(&tc.timestamp, &Rfc3339)
        1347  +
                .unwrap()
        1348  +
                .into(),
        1349  +
            settings: SigningSettings {
        1350  +
                // payload_checksum_kind: PayloadChecksumKind::XAmzSha256,
        1351  +
                expires_in: Some(Duration::from_secs(tc.expiration_in_seconds)),
        1352  +
                uri_path_normalization_mode: tc.normalize.into(),
        1353  +
                session_token_mode: if tc.omit_session_token {
        1354  +
                    SessionTokenMode::Exclude
        1355  +
                } else {
        1356  +
                    SessionTokenMode::Include
        1357  +
                },
        1358  +
                payload_checksum_kind: if tc.sign_body {
        1359  +
                    PayloadChecksumKind::XAmzSha256
        1360  +
                } else {
        1361  +
                    PayloadChecksumKind::NoHeader
        1362  +
                },
        1363  +
                ..Default::default()
        1364  +
            },
        1365  +
        }
        1366  +
    }
        1367  +
}
        1368  +
        1369  +
#[cfg(feature = "sigv4a")]
        1370  +
pub(crate) mod v4a {
        1371  +
    use super::*;
        1372  +
    use crate::http_request::{
        1373  +
        sign, PayloadChecksumKind, SessionTokenMode, SignatureLocation, SigningSettings,
        1374  +
    };
        1375  +
    use crate::sign::v4a;
        1376  +
    use p256::ecdsa::signature::{Signature, Verifier};
        1377  +
    use p256::ecdsa::{DerSignature, SigningKey};
        1378  +
    use std::time::Duration;
        1379  +
    use time::format_description::well_known::Rfc3339;
        1380  +
    use time::OffsetDateTime;
        1381  +
        1382  +
    fn new_v4a_signing_params_from_context(
        1383  +
        test_context: &'_ TestContext,
        1384  +
        signature_location: SignatureLocation,
        1385  +
    ) -> crate::http_request::SigningParams<'_> {
        1386  +
        let mut params = crate::sign::v4a::SigningParams::from(test_context);
        1387  +
        params.settings.signature_location = signature_location;
        1388  +
        params.into()
        1389  +
    }
        1390  +
        1391  +
    pub(crate) fn run_test_suite_v4a(test_name: &'static str) {
        1392  +
        run_v4a_test(test_name, SignatureLocation::Headers);
        1393  +
        run_v4a_test(test_name, SignatureLocation::QueryParams);
        1394  +
    }
        1395  +
        1396  +
    pub(crate) fn run_v4a_test(test_name: &'static str, signature_location: SignatureLocation) {
        1397  +
        let test = SigningSuiteTest::v4a(test_name);
        1398  +
        let tc = test.context();
        1399  +
        let params = new_v4a_signing_params_from_context(&tc, signature_location);
        1400  +
        1401  +
        let req = test.request();
        1402  +
        let expected_creq = test.canonical_request(signature_location);
        1403  +
        let signable_req = SignableRequest::from(&req);
        1404  +
        let actual_creq = CanonicalRequest::from(&signable_req, &params).unwrap();
        1405  +
        1406  +
        assert_eq!(
        1407  +
            expected_creq,
        1408  +
            actual_creq.to_string(),
        1409  +
            "canonical request didn't match (signature location: {signature_location:?})"
        1410  +
        );
        1411  +
        1412  +
        let expected_string_to_sign = test.string_to_sign(signature_location);
        1413  +
        let hashed_creq = &crate::sign::v4::sha256_hex_string(actual_creq.to_string().as_bytes());
        1414  +
        let actual_string_to_sign = StringToSign::new_v4a(
        1415  +
            *params.time(),
        1416  +
            params.region_set().unwrap(),
        1417  +
            params.name(),
        1418  +
            hashed_creq,
        1419  +
        )
        1420  +
        .to_string();
        1421  +
        1422  +
        assert_eq!(
        1423  +
            expected_string_to_sign, actual_string_to_sign,
        1424  +
            "'string to sign' didn't match (signature location: {signature_location:?})"
        1425  +
        );
        1426  +
        1427  +
        let out = sign(signable_req, &params).unwrap();
        1428  +
        // Sigv4a signatures are non-deterministic, so we can't compare the signature directly.
        1429  +
        out.output
        1430  +
            .apply_to_request_http0x(&mut req.as_http_request());
        1431  +
        1432  +
        let creds = params.credentials().unwrap();
        1433  +
        let signing_key =
        1434  +
            v4a::generate_signing_key(creds.access_key_id(), creds.secret_access_key());
        1435  +
        let sig = DerSignature::from_bytes(&hex::decode(out.signature).unwrap()).unwrap();
        1436  +
        let sig = sig
        1437  +
            .try_into()
        1438  +
            .expect("DER-style signatures are always convertible into fixed-size signatures");
        1439  +
        1440  +
        let signing_key = SigningKey::from_bytes(signing_key.as_ref()).unwrap();
        1441  +
        let peer_public_key = signing_key.verifying_key();
        1442  +
        let sts = actual_string_to_sign.as_bytes();
        1443  +
        peer_public_key.verify(sts, &sig).unwrap();
        1444  +
        // TODO(sigv4a) - use public.key.json as verifying key?
        1445  +
    }
        1446  +
        1447  +
    impl<'a> From<&'a TestContext> for crate::sign::v4a::SigningParams<'a, SigningSettings> {
        1448  +
        fn from(tc: &'a TestContext) -> Self {
        1449  +
            crate::sign::v4a::SigningParams {
        1450  +
                identity: &tc.identity,
        1451  +
                region_set: &tc.region,
        1452  +
                name: &tc.service,
        1453  +
                time: OffsetDateTime::parse(&tc.timestamp, &Rfc3339)
        1454  +
                    .unwrap()
        1455  +
                    .into(),
        1456  +
                settings: SigningSettings {
        1457  +
                    // payload_checksum_kind: PayloadChecksumKind::XAmzSha256,
        1458  +
                    expires_in: Some(Duration::from_secs(tc.expiration_in_seconds)),
        1459  +
                    uri_path_normalization_mode: tc.normalize.into(),
        1460  +
                    session_token_mode: if tc.omit_session_token {
        1461  +
                        SessionTokenMode::Exclude
        1462  +
                    } else {
        1463  +
                        SessionTokenMode::Include
        1464  +
                    },
        1465  +
                    payload_checksum_kind: if tc.sign_body {
        1466  +
                        PayloadChecksumKind::XAmzSha256
        1467  +
                    } else {
        1468  +
                        PayloadChecksumKind::NoHeader
        1469  +
                    },
        1470  +
                    ..Default::default()
        1471  +
                },
        1472  +
            }
        1473  +
        }
 1133   1474   
    }
 1134   1475   
 1135   1476   
    #[test]
 1136   1477   
    fn test_parse() {
 1137         -
        let req = test_request("post-header-key-case");
        1478  +
        let req = SigningSuiteTest::v4a("post-header-key-case").request();
 1138   1479   
        assert_eq!(req.method, "POST");
 1139   1480   
        assert_eq!(req.uri, "https://example.amazonaws.com/");
 1140   1481   
        assert!(req.headers.is_empty());
 1141   1482   
    }
 1142   1483   
 1143   1484   
    #[test]
 1144   1485   
    fn test_read_query_params() {
 1145         -
        let req = test_request("get-header-value-trim");
        1486  +
        let req = SigningSuiteTest::v4a("get-header-value-trim").request();
 1146   1487   
        assert_eq!(req.method, "GET");
 1147   1488   
        assert_eq!(req.uri, "https://example.amazonaws.com/");
 1148   1489   
        assert!(!req.headers.is_empty());
 1149   1490   
    }
 1150   1491   
}
 1151   1492   
 1152   1493   
fn read(path: &str) -> String {
 1153   1494   
    println!("Loading `{}` for test case...", path);
 1154   1495   
    let v = {
 1155   1496   
        match std::fs::read_to_string(path) {
 1156   1497   
            // This replacement is necessary for tests to pass on Windows, as reading the
 1157   1498   
            // test snapshots from the file system results in CRLF line endings being inserted.
 1158   1499   
            Ok(value) => value.replace("\r\n", "\n"),
 1159   1500   
            Err(err) => {
 1160   1501   
                panic!("failed to load test case `{}`: {}", path, err);
 1161   1502   
            }
 1162   1503   
        }
 1163   1504   
    };
 1164   1505   
 1165   1506   
    v.trim().to_string()
 1166   1507   
}
 1167   1508   
 1168   1509   
pub(crate) struct TestRequest {
 1169   1510   
    pub(crate) uri: String,
 1170   1511   
    pub(crate) method: String,
 1171   1512   
    pub(crate) headers: Vec<(String, String)>,
 1172   1513   
    pub(crate) body: TestSignedBody,
 1173   1514   
}
 1174   1515   
 1175   1516   
pub(crate) enum TestSignedBody {
 1176   1517   
@@ -290,79 +501,87 @@ impl<B: AsRef<[u8]>> From<http0::Request<B>> for TestRequest {
 1177   1518   
                        String::from_utf8(v.as_bytes().to_vec()).unwrap(),
 1178   1519   
                    )
 1179   1520   
                })
 1180   1521   
                .collect::<Vec<_>>(),
 1181   1522   
            body: TestSignedBody::Bytes(value.body().as_ref().to_vec()),
 1182   1523   
        }
 1183   1524   
    }
 1184   1525   
}
 1185   1526   
 1186   1527   
impl<'a> From<&'a TestRequest> for SignableRequest<'a> {
 1187   1528   
    fn from(request: &'a TestRequest) -> SignableRequest<'a> {
 1188   1529   
        SignableRequest::new(
 1189   1530   
            &request.method,
 1190   1531   
            &request.uri,
 1191   1532   
            request
 1192   1533   
                .headers
 1193   1534   
                .iter()
 1194   1535   
                .map(|(k, v)| (k.as_str(), v.as_str())),
 1195   1536   
            request.body.as_signable_body(),
 1196   1537   
        )
 1197   1538   
        .expect("URI MUST be valid")
 1198   1539   
    }
 1199   1540   
}
 1200   1541   
 1201   1542   
fn parse_request(s: &[u8]) -> Result<TestRequest, Box<dyn StdError + Send + Sync + 'static>> {
 1202   1543   
    let mut headers = [httparse::EMPTY_HEADER; 64];
 1203   1544   
    // httparse 1.5 requires two trailing newlines to head the header section.
 1204   1545   
    let mut with_newline = Vec::from(s);
 1205   1546   
    with_newline.push(b'\n');
 1206   1547   
    let mut req = httparse::Request::new(&mut headers);
 1207         -
    let _ = req.parse(&with_newline).unwrap();
        1548  +
    let status = req.parse(&with_newline).unwrap();
        1549  +
        1550  +
    let body = if status.is_complete() {
        1551  +
        let body_offset = status.unwrap();
        1552  +
        // ignore the newline we added, take from original
        1553  +
        &s[body_offset..]
        1554  +
    } else {
        1555  +
        &[]
        1556  +
    };
 1208   1557   
 1209   1558   
    let mut uri_builder = Uri::builder().scheme("https");
 1210   1559   
    if let Some(path) = req.path {
 1211   1560   
        uri_builder = uri_builder.path_and_query(path);
 1212   1561   
    }
 1213   1562   
 1214   1563   
    let mut headers = vec![];
 1215   1564   
    for header in req.headers {
 1216   1565   
        let name = header.name.to_lowercase();
 1217   1566   
        if name == "host" {
 1218   1567   
            uri_builder = uri_builder.authority(header.value);
 1219   1568   
        } else if !name.is_empty() {
 1220   1569   
            headers.push((
 1221   1570   
                header.name.to_string(),
 1222   1571   
                std::str::from_utf8(header.value)?.to_string(),
 1223   1572   
            ));
 1224   1573   
        }
 1225   1574   
    }
 1226   1575   
 1227   1576   
    Ok(TestRequest {
 1228   1577   
        uri: uri_builder.build()?.to_string(),
 1229   1578   
        method: req.method.unwrap().to_string(),
 1230   1579   
        headers,
 1231         -
        body: TestSignedBody::Bytes(vec![]),
        1580  +
        body: TestSignedBody::Bytes(Vec::from(body)),
 1232   1581   
    })
 1233   1582   
}
 1234   1583   
 1235   1584   
#[test]
 1236   1585   
fn test_parse_headers() {
 1237   1586   
    let buf = b"Host:example.amazonaws.com\nX-Amz-Date:20150830T123600Z\n\nblah blah";
 1238   1587   
    let mut headers = [httparse::EMPTY_HEADER; 4];
 1239   1588   
    assert_eq!(
 1240   1589   
        httparse::parse_headers(buf, &mut headers),
 1241   1590   
        Ok(httparse::Status::Complete((
 1242   1591   
            56,
 1243   1592   
            &[
 1244   1593   
                httparse::Header {
 1245   1594   
                    name: "Host",
 1246   1595   
                    value: b"example.amazonaws.com",
 1247   1596   
                },
 1248   1597   
                httparse::Header {
 1249   1598   
                    name: "X-Amz-Date",
 1250   1599   
                    value: b"20150830T123600Z",
 1251   1600   
                }
 1252   1601   
            ][..]
 1253   1602   
        )))
 1254   1603   
    );
 1255   1604   
}
 1256   1605   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/sign/v4.rs b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/sign/v4.rs
 1257   1606   
index a208453..fc00249 100644
 1258         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/sign/v4.rs
        1607  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-sigv4/src/sign/v4.rs
 1259   1608   
@@ -168,52 +168,54 @@ pub mod signing_params {
 1260   1609   
        );
 1261   1610   
 1262   1611   
        /// Builds an instance of [`SigningParams`]. Will yield a [`BuildError`] if
 1263   1612   
        /// a required argument was not given.
 1264   1613   
        pub fn build(self) -> Result<SigningParams<'a, S>, BuildError> {
 1265   1614   
            Ok(SigningParams {
 1266   1615   
                identity: self
 1267   1616   
                    .identity
 1268   1617   
                    .ok_or_else(|| BuildError::new("identity is required"))?,
 1269   1618   
                region: self
 1270   1619   
                    .region
 1271   1620   
                    .ok_or_else(|| BuildError::new("region is required"))?,
 1272   1621   
                name: self
 1273   1622   
                    .name
 1274   1623   
                    .ok_or_else(|| BuildError::new("name is required"))?,
 1275   1624   
                time: self
 1276   1625   
                    .time
 1277   1626   
                    .ok_or_else(|| BuildError::new("time is required"))?,
 1278   1627   
                settings: self
 1279   1628   
                    .settings
 1280   1629   
                    .ok_or_else(|| BuildError::new("settings are required"))?,
 1281   1630   
            })
 1282   1631   
        }
 1283   1632   
    }
 1284   1633   
}
 1285   1634   
 1286   1635   
#[cfg(test)]
 1287   1636   
mod tests {
 1288   1637   
    use super::{calculate_signature, generate_signing_key, sha256_hex_string};
 1289   1638   
    use crate::date_time::test_parsers::parse_date_time;
 1290         -
    use crate::http_request::test;
 1291   1639   
 1292   1640   
    #[test]
 1293   1641   
    fn test_signature_calculation() {
 1294   1642   
        let secret = "wJalrXUtnFEMI/K7MDENG+bPxRfiCYEXAMPLEKEY";
 1295         -
        let creq = test::v4::test_canonical_request("iam");
        1643  +
        let creq = r#"AWS4-HMAC-SHA256
        1644  +
20150830T123600Z
        1645  +
20150830/us-east-1/iam/aws4_request
        1646  +
f536975d06c0309214f805bb90ccff089219ecd68b2577efef23edd43b7e1a59"#;
 1296   1647   
        let time = parse_date_time("20150830T123600Z").unwrap();
 1297   1648   
 1298   1649   
        let derived_key = generate_signing_key(secret, time, "us-east-1", "iam");
 1299   1650   
        let signature = calculate_signature(derived_key, creq.as_bytes());
 1300   1651   
 1301   1652   
        let expected = "5d672d79c15b13162d9279b0855cfba6789a8edb4c82c400e06b5924a6f2b5d7";
 1302   1653   
        assert_eq!(expected, &signature);
 1303   1654   
    }
 1304   1655   
 1305   1656   
    #[test]
 1306   1657   
    fn sign_payload_empty_string() {
 1307   1658   
        let expected = "e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855";
 1308   1659   
        let actual = sha256_hex_string([]);
 1309   1660   
        assert_eq!(expected, actual);
 1310   1661   
    }
 1311   1662   
}
 1312   1663   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-checksums/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-checksums/Cargo.toml
 1313   1664   
index ce78c38..8c2f591 100644
 1314         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-checksums/Cargo.toml
        1665  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-checksums/Cargo.toml
 1315   1666   
@@ -1,43 +1,43 @@
 1316   1667   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 1317   1668   
[package]
 1318   1669   
name = "aws-smithy-checksums"
 1319   1670   
version = "0.63.5"
 1320   1671   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Zelda Hessler <zhessler@amazon.com>"]
 1321   1672   
description = "Checksum calculation and verification callbacks"
 1322   1673   
edition = "2021"
 1323   1674   
license = "Apache-2.0"
 1324   1675   
repository = "https://github.com/smithy-lang/smithy-rs"
 1325   1676   
[package.metadata.docs.rs]
 1326   1677   
all-features = true
 1327   1678   
targets = ["x86_64-unknown-linux-gnu"]
 1328   1679   
cargo-args = ["-Zunstable-options", "-Zrustdoc-scrape-examples"]
 1329   1680   
rustdoc-args = ["--cfg", "docsrs"]
 1330   1681   
 1331   1682   
[dependencies]
 1332   1683   
bytes = "1.10.0"
 1333   1684   
crc-fast = "1.3.0"
 1334   1685   
hex = "0.4.3"
 1335   1686   
http = "0.2.9"
 1336   1687   
http-body = "0.4.5"
 1337   1688   
md-5 = "0.10"
 1338   1689   
pin-project-lite = "0.2.14"
 1339   1690   
sha1 = "0.10"
 1340   1691   
sha2 = "0.10"
 1341   1692   
tracing = "0.1.40"
 1342   1693   
 1343   1694   
[dependencies.aws-smithy-http]
 1344   1695   
path = "../aws-smithy-http"
 1345         -
version = "0.62.2"
        1696  +
version = "0.62.3"
 1346   1697   
 1347   1698   
[dependencies.aws-smithy-types]
 1348   1699   
path = "../aws-smithy-types"
 1349   1700   
version = "1.3.2"
 1350   1701   
 1351   1702   
[dev-dependencies]
 1352   1703   
bytes-utils = "0.1.2"
 1353   1704   
pretty_assertions = "1.3"
 1354   1705   
tracing-test = "0.2.1"
 1355   1706   
 1356   1707   
[dev-dependencies.tokio]
 1357   1708   
version = "1.23.1"
 1358   1709   
features = ["macros", "rt"]
 1359   1710   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/Cargo.toml
 1360   1711   
index 970c99e..d3c7a49 100644
 1361         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/Cargo.toml
        1712  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/Cargo.toml
 1362   1713   
@@ -1,34 +1,34 @@
 1363   1714   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 1364   1715   
[package]
 1365   1716   
name = "aws-smithy-http"
 1366         -
version = "0.62.2"
        1717  +
version = "0.62.3"
 1367   1718   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 1368   1719   
description = "Smithy HTTP logic for smithy-rs."
 1369   1720   
edition = "2021"
 1370   1721   
license = "Apache-2.0"
 1371   1722   
repository = "https://github.com/smithy-lang/smithy-rs"
 1372   1723   
[package.metadata.docs.rs]
 1373   1724   
all-features = true
 1374   1725   
targets = ["x86_64-unknown-linux-gnu"]
 1375   1726   
cargo-args = ["-Zunstable-options", "-Zrustdoc-scrape-examples"]
 1376   1727   
rustdoc-args = ["--cfg", "docsrs"]
 1377   1728   
 1378   1729   
[features]
 1379   1730   
event-stream = ["aws-smithy-eventstream"]
 1380   1731   
rt-tokio = ["aws-smithy-types/rt-tokio"]
 1381   1732   
 1382   1733   
[dependencies]
 1383   1734   
bytes = "1.10.0"
 1384   1735   
bytes-utils = "0.1"
 1385   1736   
percent-encoding = "2.3.1"
 1386   1737   
pin-project-lite = "0.2.14"
 1387   1738   
pin-utils = "0.1.0"
 1388   1739   
tracing = "0.1.40"
 1389   1740   
futures-core = "0.3.31"
 1390   1741   
 1391   1742   
[dependencies.aws-smithy-eventstream]
 1392   1743   
path = "../aws-smithy-eventstream"
 1393   1744   
optional = true
 1394   1745   
version = "0.60.10"
 1395   1746   
 1396   1747   
[dependencies.aws-smithy-runtime-api]
 1397   1748   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/fuzz/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/fuzz/Cargo.toml
 1398   1749   
index 508f7a2..361545e 100644
 1399         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/fuzz/Cargo.toml
        1750  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/fuzz/Cargo.toml
 1400   1751   
@@ -1,27 +1,27 @@
 1401   1752   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 1402   1753   
[[bin]]
 1403   1754   
name = "read_many_from_str"
 1404   1755   
path = "fuzz_targets/read_many_from_str.rs"
 1405   1756   
test = false
 1406   1757   
doc = false
 1407   1758   
 1408   1759   
[package]
 1409   1760   
name = "aws-smithy-http-fuzz"
 1410   1761   
version = "0.0.0"
 1411   1762   
authors = ["Automatically generated"]
 1412   1763   
publish = false
 1413   1764   
edition = "2021"
 1414   1765   
 1415   1766   
[package.metadata]
 1416   1767   
cargo-fuzz = true
 1417   1768   
 1418   1769   
[dependencies]
 1419   1770   
libfuzzer-sys = "=0.4.7"
 1420   1771   
http = "0.2.3"
 1421   1772   
 1422   1773   
[dependencies.aws-smithy-http]
 1423   1774   
path = ".."
 1424         -
version = "0.62.2"
        1775  +
version = "0.62.3"
 1425   1776   
 1426   1777   
[workspace]
 1427   1778   
members = ["."]
 1428   1779   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/src/query_writer.rs b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/src/query_writer.rs
 1429   1780   
index fef41d0..7694da6 100644
 1430         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/src/query_writer.rs
        1781  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-http/src/query_writer.rs
 1431   1782   
@@ -25,68 +25,73 @@ impl QueryWriter {
 1432   1783   
    pub fn new(uri: &Uri) -> Self {
 1433   1784   
        let new_path_and_query = uri
 1434   1785   
            .path_and_query()
 1435   1786   
            .map(|pq| pq.to_string())
 1436   1787   
            .unwrap_or_default();
 1437   1788   
        let prefix = if uri.query().is_none() {
 1438   1789   
            Some('?')
 1439   1790   
        } else if !uri.query().unwrap_or_default().is_empty() {
 1440   1791   
            Some('&')
 1441   1792   
        } else {
 1442   1793   
            None
 1443   1794   
        };
 1444   1795   
        QueryWriter {
 1445   1796   
            base_uri: uri.clone(),
 1446   1797   
            new_path_and_query,
 1447   1798   
            prefix,
 1448   1799   
        }
 1449   1800   
    }
 1450   1801   
 1451   1802   
    /// Clears all query parameters.
 1452   1803   
    pub fn clear_params(&mut self) {
 1453   1804   
        if let Some(index) = self.new_path_and_query.find('?') {
 1454   1805   
            self.new_path_and_query.truncate(index);
 1455   1806   
            self.prefix = Some('?');
 1456   1807   
        }
 1457   1808   
    }
 1458   1809   
 1459   1810   
    /// Inserts a new query parameter. The key and value are percent encoded
 1460   1811   
    /// by `QueryWriter`. Passing in percent encoded values will result in double encoding.
 1461   1812   
    pub fn insert(&mut self, k: &str, v: &str) {
        1813  +
        self.insert_encoded(&percent_encode_query(k), &percent_encode_query(v));
        1814  +
    }
        1815  +
        1816  +
    /// Inserts a new already encoded query parameter. The key and value will be inserted
        1817  +
    /// as is.
        1818  +
    pub fn insert_encoded(&mut self, encoded_k: &str, encoded_v: &str) {
 1462   1819   
        if let Some(prefix) = self.prefix {
 1463   1820   
            self.new_path_and_query.push(prefix);
 1464   1821   
        }
 1465   1822   
        self.prefix = Some('&');
 1466         -
        self.new_path_and_query.push_str(&percent_encode_query(k));
        1823  +
        self.new_path_and_query.push_str(encoded_k);
 1467   1824   
        self.new_path_and_query.push('=');
 1468         -
 1469         -
        self.new_path_and_query.push_str(&percent_encode_query(v));
        1825  +
        self.new_path_and_query.push_str(encoded_v)
 1470   1826   
    }
 1471   1827   
 1472   1828   
    /// Returns just the built query string.
 1473   1829   
    pub fn build_query(self) -> String {
 1474   1830   
        self.build_uri().query().unwrap_or_default().to_string()
 1475   1831   
    }
 1476   1832   
 1477   1833   
    /// Returns a full [`Uri`] with the query string updated.
 1478   1834   
    pub fn build_uri(self) -> Uri {
 1479   1835   
        let mut parts = self.base_uri.into_parts();
 1480   1836   
        parts.path_and_query = Some(
 1481   1837   
            self.new_path_and_query
 1482   1838   
                .parse()
 1483   1839   
                .expect("adding query should not invalidate URI"),
 1484   1840   
        );
 1485   1841   
        Uri::from_parts(parts).expect("a valid URL in should always produce a valid URL out")
 1486   1842   
    }
 1487   1843   
}
 1488   1844   
 1489   1845   
#[cfg(test)]
 1490   1846   
mod test {
 1491   1847   
    use super::QueryWriter;
 1492   1848   
    use http_02x::Uri;
 1493   1849   
 1494   1850   
    #[test]
 1495   1851   
    fn empty_uri() {
 1496   1852   
        let uri = Uri::from_static("http://www.example.com");
 1497   1853   
        let mut query_writer = QueryWriter::new(&uri);
 1498   1854   
        query_writer.insert("key", "val%ue");
 1499   1855   
        query_writer.insert("another", "value");
 1500   1856   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-runtime/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-runtime/Cargo.toml
 1501   1857   
index f108978..df7a9fe 100644
 1502         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-runtime/Cargo.toml
        1858  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-runtime/Cargo.toml
 1503   1859   
@@ -15,61 +15,61 @@ rustdoc-args = ["--cfg", "docsrs"]
 1504   1860   
 1505   1861   
[package.metadata.smithy-rs-release-tooling]
 1506   1862   
stable = true
 1507   1863   
[package.metadata.cargo-udeps.ignore]
 1508   1864   
normal = ["aws-smithy-http"]
 1509   1865   
 1510   1866   
[features]
 1511   1867   
client = ["aws-smithy-runtime-api/client", "aws-smithy-types/http-body-1-x"]
 1512   1868   
http-auth = ["aws-smithy-runtime-api/http-auth"]
 1513   1869   
connector-hyper-0-14-x = ["dep:aws-smithy-http-client", "aws-smithy-http-client?/hyper-014"]
 1514   1870   
tls-rustls = ["dep:aws-smithy-http-client", "aws-smithy-http-client?/legacy-rustls-ring", "connector-hyper-0-14-x"]
 1515   1871   
default-https-client = ["dep:aws-smithy-http-client", "aws-smithy-http-client?/rustls-aws-lc"]
 1516   1872   
rt-tokio = ["tokio/rt"]
 1517   1873   
test-util = ["aws-smithy-runtime-api/test-util", "dep:tracing-subscriber", "aws-smithy-http-client/test-util", "legacy-test-util"]
 1518   1874   
legacy-test-util = ["aws-smithy-runtime-api/test-util", "dep:tracing-subscriber", "aws-smithy-http-client/test-util", "connector-hyper-0-14-x", "aws-smithy-http-client/legacy-test-util"]
 1519   1875   
wire-mock = ["legacy-test-util", "aws-smithy-http-client/wire-mock"]
 1520   1876   
 1521   1877   
[dependencies]
 1522   1878   
bytes = "1.10.0"
 1523   1879   
fastrand = "2.3.0"
 1524   1880   
pin-project-lite = "0.2.14"
 1525   1881   
pin-utils = "0.1.0"
 1526   1882   
tracing = "0.1.40"
 1527   1883   
 1528   1884   
[dependencies.aws-smithy-async]
 1529   1885   
path = "../aws-smithy-async"
 1530   1886   
version = "1.2.5"
 1531   1887   
 1532   1888   
[dependencies.aws-smithy-http]
 1533   1889   
path = "../aws-smithy-http"
 1534         -
version = "0.62.2"
        1890  +
version = "0.62.3"
 1535   1891   
 1536   1892   
[dependencies.aws-smithy-observability]
 1537   1893   
path = "../aws-smithy-observability"
 1538   1894   
version = "0.1.3"
 1539   1895   
 1540   1896   
[dependencies.aws-smithy-runtime-api]
 1541   1897   
path = "../aws-smithy-runtime-api"
 1542   1898   
version = "1.8.5"
 1543   1899   
 1544   1900   
[dependencies.aws-smithy-types]
 1545   1901   
path = "../aws-smithy-types"
 1546   1902   
features = ["http-body-0-4-x"]
 1547   1903   
version = "1.3.2"
 1548   1904   
 1549   1905   
[dependencies.aws-smithy-http-client]
 1550   1906   
path = "../aws-smithy-http-client"
 1551   1907   
optional = true
 1552   1908   
version = "1.0.6"
 1553   1909   
 1554   1910   
[dependencies.http-02x]
 1555   1911   
package = "http"
 1556   1912   
version = "0.2.9"
 1557   1913   
 1558   1914   
[dependencies.http-1x]
 1559   1915   
package = "http"
 1560   1916   
version = "1"
 1561   1917   
 1562   1918   
[dependencies.http-body-04x]
 1563   1919   
package = "http-body"
 1564   1920   
version = "0.4.5"
 1565   1921   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-wasm/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-wasm/Cargo.toml
 1566   1922   
index 4e050c6..f58eb1c 100644
 1567         -
-- a/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-wasm/Cargo.toml
        1923  +
++ b/tmp-codegen-diff/aws-sdk/sdk/aws-smithy-wasm/Cargo.toml
 1568   1924   
@@ -1,33 +1,33 @@
 1569   1925   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 1570   1926   
[package]
 1571   1927   
name = "aws-smithy-wasm"
 1572   1928   
version = "0.1.4"
 1573   1929   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Eduardo Rodrigues <16357187+eduardomourar@users.noreply.github.com>"]
 1574   1930   
description = "Smithy WebAssembly configuration for smithy-rs."
 1575   1931   
edition = "2021"
 1576   1932   
license = "Apache-2.0"
 1577   1933   
repository = "https://github.com/awslabs/smithy-rs"
 1578   1934   
[package.metadata.docs.rs]
 1579   1935   
all-features = true
 1580   1936   
targets = ["x86_64-unknown-linux-gnu"]
 1581   1937   
cargo-args = ["-Zunstable-options", "-Zrustdoc-scrape-examples"]
 1582   1938   
rustdoc-args = ["--cfg", "docsrs"]
 1583   1939   
 1584   1940   
[dependencies]
 1585   1941   
bytes = "1.10.0"
 1586   1942   
http = "1.0.0"
 1587   1943   
tracing = "0.1.40"
 1588   1944   
wasi = "0.12.1"
 1589   1945   
 1590   1946   
[dependencies.aws-smithy-runtime-api]
 1591   1947   
path = "../aws-smithy-runtime-api"
 1592   1948   
features = ["http-1x"]
 1593   1949   
version = "1.8.5"
 1594   1950   
 1595   1951   
[dependencies.aws-smithy-http]
 1596   1952   
path = "../aws-smithy-http"
 1597         -
version = "0.62.2"
        1953  +
version = "0.62.3"
 1598   1954   
 1599   1955   
[dependencies.aws-smithy-types]
 1600   1956   
path = "../aws-smithy-types"
 1601   1957   
version = "1.3.2"
 1602   1958   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/bedrockruntime/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/bedrockruntime/Cargo.toml
 1603   1959   
index a880648..139e808 100644
 1604         -
-- a/tmp-codegen-diff/aws-sdk/sdk/bedrockruntime/Cargo.toml
        1960  +
++ b/tmp-codegen-diff/aws-sdk/sdk/bedrockruntime/Cargo.toml
 1605   1961   
@@ -7,61 +7,61 @@ description = "AWS SDK for Amazon Bedrock Runtime"
 1606   1962   
edition = "2021"
 1607   1963   
license = "Apache-2.0"
 1608   1964   
repository = "https://github.com/awslabs/aws-sdk-rust"
 1609   1965   
rust-version = "1.86.0"
 1610   1966   
readme = "README.md"
 1611   1967   
[package.metadata.smithy]
 1612   1968   
codegen-version = "ci"
 1613   1969   
[package.metadata.docs.rs]
 1614   1970   
all-features = true
 1615   1971   
targets = ["x86_64-unknown-linux-gnu"]
 1616   1972   
[dependencies.aws-credential-types]
 1617   1973   
path = "../aws-credential-types"
 1618   1974   
version = "1.2.4"
 1619   1975   
 1620   1976   
[dependencies.aws-runtime]
 1621   1977   
path = "../aws-runtime"
 1622   1978   
features = ["event-stream"]
 1623   1979   
version = "1.5.9"
 1624   1980   
 1625   1981   
[dependencies.aws-smithy-async]
 1626   1982   
path = "../aws-smithy-async"
 1627   1983   
version = "1.2.5"
 1628   1984   
 1629   1985   
[dependencies.aws-smithy-eventstream]
 1630   1986   
path = "../aws-smithy-eventstream"
 1631   1987   
version = "0.60.10"
 1632   1988   
 1633   1989   
[dependencies.aws-smithy-http]
 1634   1990   
path = "../aws-smithy-http"
 1635   1991   
features = ["event-stream"]
 1636         -
version = "0.62.2"
        1992  +
version = "0.62.3"
 1637   1993   
 1638   1994   
[dependencies.aws-smithy-json]
 1639   1995   
path = "../aws-smithy-json"
 1640   1996   
version = "0.61.4"
 1641   1997   
 1642   1998   
[dependencies.aws-smithy-runtime]
 1643   1999   
path = "../aws-smithy-runtime"
 1644   2000   
features = ["client"]
 1645   2001   
version = "1.8.5"
 1646   2002   
 1647   2003   
[dependencies.aws-smithy-runtime-api]
 1648   2004   
path = "../aws-smithy-runtime-api"
 1649   2005   
features = ["client", "http-02x"]
 1650   2006   
version = "1.8.5"
 1651   2007   
 1652   2008   
[dependencies.aws-smithy-types]
 1653   2009   
path = "../aws-smithy-types"
 1654   2010   
version = "1.3.2"
 1655   2011   
 1656   2012   
[dependencies.aws-types]
 1657   2013   
path = "../aws-types"
 1658   2014   
version = "1.3.8"
 1659   2015   
 1660   2016   
[dependencies.bytes]
 1661   2017   
version = "1.4.0"
 1662   2018   
 1663   2019   
[dependencies.fastrand]
 1664   2020   
version = "2.0.0"
 1665   2021   
 1666   2022   
[dependencies.http]
 1667   2023   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/cloudwatchlogs/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/cloudwatchlogs/Cargo.toml
 1668   2024   
index 415ecc9..667d12b 100644
 1669         -
-- a/tmp-codegen-diff/aws-sdk/sdk/cloudwatchlogs/Cargo.toml
        2025  +
++ b/tmp-codegen-diff/aws-sdk/sdk/cloudwatchlogs/Cargo.toml
 1670   2026   
@@ -7,61 +7,61 @@ description = "AWS SDK for Amazon CloudWatch Logs"
 1671   2027   
edition = "2021"
 1672   2028   
license = "Apache-2.0"
 1673   2029   
repository = "https://github.com/awslabs/aws-sdk-rust"
 1674   2030   
rust-version = "1.86.0"
 1675   2031   
readme = "README.md"
 1676   2032   
[package.metadata.smithy]
 1677   2033   
codegen-version = "ci"
 1678   2034   
[package.metadata.docs.rs]
 1679   2035   
all-features = true
 1680   2036   
targets = ["x86_64-unknown-linux-gnu"]
 1681   2037   
[dependencies.aws-credential-types]
 1682   2038   
path = "../aws-credential-types"
 1683   2039   
version = "1.2.4"
 1684   2040   
 1685   2041   
[dependencies.aws-runtime]
 1686   2042   
path = "../aws-runtime"
 1687   2043   
features = ["event-stream"]
 1688   2044   
version = "1.5.9"
 1689   2045   
 1690   2046   
[dependencies.aws-smithy-async]
 1691   2047   
path = "../aws-smithy-async"
 1692   2048   
version = "1.2.5"
 1693   2049   
 1694   2050   
[dependencies.aws-smithy-eventstream]
 1695   2051   
path = "../aws-smithy-eventstream"
 1696   2052   
version = "0.60.10"
 1697   2053   
 1698   2054   
[dependencies.aws-smithy-http]
 1699   2055   
path = "../aws-smithy-http"
 1700   2056   
features = ["event-stream"]
 1701         -
version = "0.62.2"
        2057  +
version = "0.62.3"
 1702   2058   
 1703   2059   
[dependencies.aws-smithy-json]
 1704   2060   
path = "../aws-smithy-json"
 1705   2061   
version = "0.61.4"
 1706   2062   
 1707   2063   
[dependencies.aws-smithy-runtime]
 1708   2064   
path = "../aws-smithy-runtime"
 1709   2065   
features = ["client"]
 1710   2066   
version = "1.8.5"
 1711   2067   
 1712   2068   
[dependencies.aws-smithy-runtime-api]
 1713   2069   
path = "../aws-smithy-runtime-api"
 1714   2070   
features = ["client", "http-02x"]
 1715   2071   
version = "1.8.5"
 1716   2072   
 1717   2073   
[dependencies.aws-smithy-types]
 1718   2074   
path = "../aws-smithy-types"
 1719   2075   
version = "1.3.2"
 1720   2076   
 1721   2077   
[dependencies.aws-types]
 1722   2078   
path = "../aws-types"
 1723   2079   
version = "1.3.8"
 1724   2080   
 1725   2081   
[dependencies.bytes]
 1726   2082   
version = "1.4.0"
 1727   2083   
 1728   2084   
[dependencies.fastrand]
 1729   2085   
version = "2.0.0"
 1730   2086   
 1731   2087   
[dependencies.http]
 1732   2088   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/codecatalyst/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/codecatalyst/Cargo.toml
 1733   2089   
index 8871cab..ed88de6 100644
 1734         -
-- a/tmp-codegen-diff/aws-sdk/sdk/codecatalyst/Cargo.toml
        2090  +
++ b/tmp-codegen-diff/aws-sdk/sdk/codecatalyst/Cargo.toml
 1735   2091   
@@ -1,61 +1,61 @@
 1736   2092   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 1737   2093   
[package]
 1738   2094   
name = "aws-sdk-codecatalyst"
 1739   2095   
version = "0.0.0-local"
 1740   2096   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 1741   2097   
description = "AWS SDK for Amazon CodeCatalyst"
 1742   2098   
edition = "2021"
 1743   2099   
license = "Apache-2.0"
 1744   2100   
repository = "https://github.com/awslabs/aws-sdk-rust"
 1745   2101   
rust-version = "1.86.0"
 1746   2102   
readme = "README.md"
 1747   2103   
[package.metadata.smithy]
 1748   2104   
codegen-version = "ci"
 1749   2105   
[package.metadata.docs.rs]
 1750   2106   
all-features = true
 1751   2107   
targets = ["x86_64-unknown-linux-gnu"]
 1752   2108   
[dependencies.aws-credential-types]
 1753   2109   
path = "../aws-credential-types"
 1754   2110   
version = "1.2.4"
 1755   2111   
 1756   2112   
[dependencies.aws-runtime]
 1757   2113   
path = "../aws-runtime"
 1758   2114   
version = "1.5.9"
 1759   2115   
 1760   2116   
[dependencies.aws-smithy-async]
 1761   2117   
path = "../aws-smithy-async"
 1762   2118   
version = "1.2.5"
 1763   2119   
 1764   2120   
[dependencies.aws-smithy-http]
 1765   2121   
path = "../aws-smithy-http"
 1766         -
version = "0.62.2"
        2122  +
version = "0.62.3"
 1767   2123   
 1768   2124   
[dependencies.aws-smithy-json]
 1769   2125   
path = "../aws-smithy-json"
 1770   2126   
version = "0.61.4"
 1771   2127   
 1772   2128   
[dependencies.aws-smithy-runtime]
 1773   2129   
path = "../aws-smithy-runtime"
 1774   2130   
features = ["client", "http-auth"]
 1775   2131   
version = "1.8.5"
 1776   2132   
 1777   2133   
[dependencies.aws-smithy-runtime-api]
 1778   2134   
path = "../aws-smithy-runtime-api"
 1779   2135   
features = ["client", "http-02x", "http-auth"]
 1780   2136   
version = "1.8.5"
 1781   2137   
 1782   2138   
[dependencies.aws-smithy-types]
 1783   2139   
path = "../aws-smithy-types"
 1784   2140   
version = "1.3.2"
 1785   2141   
 1786   2142   
[dependencies.aws-types]
 1787   2143   
path = "../aws-types"
 1788   2144   
version = "1.3.8"
 1789   2145   
 1790   2146   
[dependencies.bytes]
 1791   2147   
version = "1.4.0"
 1792   2148   
 1793   2149   
[dependencies.fastrand]
 1794   2150   
version = "2.0.0"
 1795   2151   
 1796   2152   
[dependencies.http]
 1797   2153   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/config/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/config/Cargo.toml
 1798   2154   
index 89573ff..05238af 100644
 1799         -
-- a/tmp-codegen-diff/aws-sdk/sdk/config/Cargo.toml
        2155  +
++ b/tmp-codegen-diff/aws-sdk/sdk/config/Cargo.toml
 1800   2156   
@@ -1,61 +1,61 @@
 1801   2157   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 1802   2158   
[package]
 1803   2159   
name = "aws-sdk-config"
 1804   2160   
version = "0.0.0-local"
 1805   2161   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 1806   2162   
description = "AWS SDK for AWS Config"
 1807   2163   
edition = "2021"
 1808   2164   
license = "Apache-2.0"
 1809   2165   
repository = "https://github.com/awslabs/aws-sdk-rust"
 1810   2166   
rust-version = "1.86.0"
 1811   2167   
readme = "README.md"
 1812   2168   
[package.metadata.smithy]
 1813   2169   
codegen-version = "ci"
 1814   2170   
[package.metadata.docs.rs]
 1815   2171   
all-features = true
 1816   2172   
targets = ["x86_64-unknown-linux-gnu"]
 1817   2173   
[dependencies.aws-credential-types]
 1818   2174   
path = "../aws-credential-types"
 1819   2175   
version = "1.2.4"
 1820   2176   
 1821   2177   
[dependencies.aws-runtime]
 1822   2178   
path = "../aws-runtime"
 1823   2179   
version = "1.5.9"
 1824   2180   
 1825   2181   
[dependencies.aws-smithy-async]
 1826   2182   
path = "../aws-smithy-async"
 1827   2183   
version = "1.2.5"
 1828   2184   
 1829   2185   
[dependencies.aws-smithy-http]
 1830   2186   
path = "../aws-smithy-http"
 1831         -
version = "0.62.2"
        2187  +
version = "0.62.3"
 1832   2188   
 1833   2189   
[dependencies.aws-smithy-json]
 1834   2190   
path = "../aws-smithy-json"
 1835   2191   
version = "0.61.4"
 1836   2192   
 1837   2193   
[dependencies.aws-smithy-runtime]
 1838   2194   
path = "../aws-smithy-runtime"
 1839   2195   
features = ["client"]
 1840   2196   
version = "1.8.5"
 1841   2197   
 1842   2198   
[dependencies.aws-smithy-runtime-api]
 1843   2199   
path = "../aws-smithy-runtime-api"
 1844   2200   
features = ["client", "http-02x"]
 1845   2201   
version = "1.8.5"
 1846   2202   
 1847   2203   
[dependencies.aws-smithy-types]
 1848   2204   
path = "../aws-smithy-types"
 1849   2205   
version = "1.3.2"
 1850   2206   
 1851   2207   
[dependencies.aws-types]
 1852   2208   
path = "../aws-types"
 1853   2209   
version = "1.3.8"
 1854   2210   
 1855   2211   
[dependencies.bytes]
 1856   2212   
version = "1.4.0"
 1857   2213   
 1858   2214   
[dependencies.fastrand]
 1859   2215   
version = "2.0.0"
 1860   2216   
 1861   2217   
[dependencies.http]
 1862   2218   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/dynamodb/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/dynamodb/Cargo.toml
 1863   2219   
index d397c58..2c1062b 100644
 1864         -
-- a/tmp-codegen-diff/aws-sdk/sdk/dynamodb/Cargo.toml
        2220  +
++ b/tmp-codegen-diff/aws-sdk/sdk/dynamodb/Cargo.toml
 1865   2221   
@@ -1,61 +1,61 @@
 1866   2222   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 1867   2223   
[package]
 1868   2224   
name = "aws-sdk-dynamodb"
 1869   2225   
version = "0.0.0-local"
 1870   2226   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 1871   2227   
description = "AWS SDK for Amazon DynamoDB"
 1872   2228   
edition = "2021"
 1873   2229   
license = "Apache-2.0"
 1874   2230   
repository = "https://github.com/awslabs/aws-sdk-rust"
 1875   2231   
rust-version = "1.86.0"
 1876   2232   
readme = "README.md"
 1877   2233   
[package.metadata.smithy]
 1878   2234   
codegen-version = "ci"
 1879   2235   
[package.metadata.docs.rs]
 1880   2236   
all-features = true
 1881   2237   
targets = ["x86_64-unknown-linux-gnu"]
 1882   2238   
[dependencies.aws-credential-types]
 1883   2239   
path = "../aws-credential-types"
 1884   2240   
version = "1.2.4"
 1885   2241   
 1886   2242   
[dependencies.aws-runtime]
 1887   2243   
path = "../aws-runtime"
 1888   2244   
version = "1.5.9"
 1889   2245   
 1890   2246   
[dependencies.aws-smithy-async]
 1891   2247   
path = "../aws-smithy-async"
 1892   2248   
version = "1.2.5"
 1893   2249   
 1894   2250   
[dependencies.aws-smithy-http]
 1895   2251   
path = "../aws-smithy-http"
 1896         -
version = "0.62.2"
        2252  +
version = "0.62.3"
 1897   2253   
 1898   2254   
[dependencies.aws-smithy-json]
 1899   2255   
path = "../aws-smithy-json"
 1900   2256   
version = "0.61.4"
 1901   2257   
 1902   2258   
[dependencies.aws-smithy-runtime]
 1903   2259   
path = "../aws-smithy-runtime"
 1904   2260   
features = ["client"]
 1905   2261   
version = "1.8.5"
 1906   2262   
 1907   2263   
[dependencies.aws-smithy-runtime-api]
 1908   2264   
path = "../aws-smithy-runtime-api"
 1909   2265   
features = ["client", "http-02x"]
 1910   2266   
version = "1.8.5"
 1911   2267   
 1912   2268   
[dependencies.aws-smithy-types]
 1913   2269   
path = "../aws-smithy-types"
 1914   2270   
version = "1.3.2"
 1915   2271   
 1916   2272   
[dependencies.aws-types]
 1917   2273   
path = "../aws-types"
 1918   2274   
version = "1.3.8"
 1919   2275   
 1920   2276   
[dependencies.bytes]
 1921   2277   
version = "1.4.0"
 1922   2278   
 1923   2279   
[dependencies.fastrand]
 1924   2280   
version = "2.0.0"
 1925   2281   
 1926   2282   
[dependencies.http]
 1927   2283   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/ec2/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/ec2/Cargo.toml
 1928   2284   
index c0ba315..46168af 100644
 1929         -
-- a/tmp-codegen-diff/aws-sdk/sdk/ec2/Cargo.toml
        2285  +
++ b/tmp-codegen-diff/aws-sdk/sdk/ec2/Cargo.toml
 1930   2286   
@@ -1,61 +1,61 @@
 1931   2287   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 1932   2288   
[package]
 1933   2289   
name = "aws-sdk-ec2"
 1934   2290   
version = "0.0.0-local"
 1935   2291   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 1936   2292   
description = "AWS SDK for Amazon Elastic Compute Cloud"
 1937   2293   
edition = "2021"
 1938   2294   
license = "Apache-2.0"
 1939   2295   
repository = "https://github.com/awslabs/aws-sdk-rust"
 1940   2296   
rust-version = "1.86.0"
 1941   2297   
readme = "README.md"
 1942   2298   
[package.metadata.smithy]
 1943   2299   
codegen-version = "ci"
 1944   2300   
[package.metadata.docs.rs]
 1945   2301   
all-features = true
 1946   2302   
targets = ["x86_64-unknown-linux-gnu"]
 1947   2303   
[dependencies.aws-credential-types]
 1948   2304   
path = "../aws-credential-types"
 1949   2305   
version = "1.2.4"
 1950   2306   
 1951   2307   
[dependencies.aws-runtime]
 1952   2308   
path = "../aws-runtime"
 1953   2309   
version = "1.5.9"
 1954   2310   
 1955   2311   
[dependencies.aws-smithy-async]
 1956   2312   
path = "../aws-smithy-async"
 1957   2313   
version = "1.2.5"
 1958   2314   
 1959   2315   
[dependencies.aws-smithy-http]
 1960   2316   
path = "../aws-smithy-http"
 1961         -
version = "0.62.2"
        2317  +
version = "0.62.3"
 1962   2318   
 1963   2319   
[dependencies.aws-smithy-json]
 1964   2320   
path = "../aws-smithy-json"
 1965   2321   
version = "0.61.4"
 1966   2322   
 1967   2323   
[dependencies.aws-smithy-query]
 1968   2324   
path = "../aws-smithy-query"
 1969   2325   
version = "0.60.7"
 1970   2326   
 1971   2327   
[dependencies.aws-smithy-runtime]
 1972   2328   
path = "../aws-smithy-runtime"
 1973   2329   
features = ["client"]
 1974   2330   
version = "1.8.5"
 1975   2331   
 1976   2332   
[dependencies.aws-smithy-runtime-api]
 1977   2333   
path = "../aws-smithy-runtime-api"
 1978   2334   
features = ["client", "http-02x"]
 1979   2335   
version = "1.8.5"
 1980   2336   
 1981   2337   
[dependencies.aws-smithy-types]
 1982   2338   
path = "../aws-smithy-types"
 1983   2339   
version = "1.3.2"
 1984   2340   
 1985   2341   
[dependencies.aws-smithy-xml]
 1986   2342   
path = "../aws-smithy-xml"
 1987   2343   
version = "0.60.10"
 1988   2344   
 1989   2345   
[dependencies.aws-types]
 1990   2346   
path = "../aws-types"
 1991   2347   
version = "1.3.8"
 1992   2348   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/ecs/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/ecs/Cargo.toml
 1993   2349   
index 4474d17..095d40e 100644
 1994         -
-- a/tmp-codegen-diff/aws-sdk/sdk/ecs/Cargo.toml
        2350  +
++ b/tmp-codegen-diff/aws-sdk/sdk/ecs/Cargo.toml
 1995   2351   
@@ -1,61 +1,61 @@
 1996   2352   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 1997   2353   
[package]
 1998   2354   
name = "aws-sdk-ecs"
 1999   2355   
version = "0.0.0-local"
 2000   2356   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2001   2357   
description = "AWS SDK for Amazon EC2 Container Service"
 2002   2358   
edition = "2021"
 2003   2359   
license = "Apache-2.0"
 2004   2360   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2005   2361   
rust-version = "1.86.0"
 2006   2362   
readme = "README.md"
 2007   2363   
[package.metadata.smithy]
 2008   2364   
codegen-version = "ci"
 2009   2365   
[package.metadata.docs.rs]
 2010   2366   
all-features = true
 2011   2367   
targets = ["x86_64-unknown-linux-gnu"]
 2012   2368   
[dependencies.aws-credential-types]
 2013   2369   
path = "../aws-credential-types"
 2014   2370   
version = "1.2.4"
 2015   2371   
 2016   2372   
[dependencies.aws-runtime]
 2017   2373   
path = "../aws-runtime"
 2018   2374   
version = "1.5.9"
 2019   2375   
 2020   2376   
[dependencies.aws-smithy-async]
 2021   2377   
path = "../aws-smithy-async"
 2022   2378   
version = "1.2.5"
 2023   2379   
 2024   2380   
[dependencies.aws-smithy-http]
 2025   2381   
path = "../aws-smithy-http"
 2026         -
version = "0.62.2"
        2382  +
version = "0.62.3"
 2027   2383   
 2028   2384   
[dependencies.aws-smithy-json]
 2029   2385   
path = "../aws-smithy-json"
 2030   2386   
version = "0.61.4"
 2031   2387   
 2032   2388   
[dependencies.aws-smithy-runtime]
 2033   2389   
path = "../aws-smithy-runtime"
 2034   2390   
features = ["client"]
 2035   2391   
version = "1.8.5"
 2036   2392   
 2037   2393   
[dependencies.aws-smithy-runtime-api]
 2038   2394   
path = "../aws-smithy-runtime-api"
 2039   2395   
features = ["client", "http-02x"]
 2040   2396   
version = "1.8.5"
 2041   2397   
 2042   2398   
[dependencies.aws-smithy-types]
 2043   2399   
path = "../aws-smithy-types"
 2044   2400   
version = "1.3.2"
 2045   2401   
 2046   2402   
[dependencies.aws-types]
 2047   2403   
path = "../aws-types"
 2048   2404   
version = "1.3.8"
 2049   2405   
 2050   2406   
[dependencies.bytes]
 2051   2407   
version = "1.4.0"
 2052   2408   
 2053   2409   
[dependencies.fastrand]
 2054   2410   
version = "2.0.0"
 2055   2411   
 2056   2412   
[dependencies.http]
 2057   2413   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/glacier/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/glacier/Cargo.toml
 2058   2414   
index 15b1d77..16d7d89 100644
 2059         -
-- a/tmp-codegen-diff/aws-sdk/sdk/glacier/Cargo.toml
        2415  +
++ b/tmp-codegen-diff/aws-sdk/sdk/glacier/Cargo.toml
 2060   2416   
@@ -1,65 +1,65 @@
 2061   2417   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2062   2418   
[package]
 2063   2419   
name = "aws-sdk-glacier"
 2064   2420   
version = "0.0.0-local"
 2065   2421   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2066   2422   
description = "AWS SDK for Amazon Glacier"
 2067   2423   
edition = "2021"
 2068   2424   
license = "Apache-2.0"
 2069   2425   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2070   2426   
rust-version = "1.86.0"
 2071   2427   
readme = "README.md"
 2072   2428   
[package.metadata.smithy]
 2073   2429   
codegen-version = "ci"
 2074   2430   
[package.metadata.docs.rs]
 2075   2431   
all-features = true
 2076   2432   
targets = ["x86_64-unknown-linux-gnu"]
 2077   2433   
[dependencies.aws-credential-types]
 2078   2434   
path = "../aws-credential-types"
 2079   2435   
version = "1.2.4"
 2080   2436   
 2081   2437   
[dependencies.aws-runtime]
 2082   2438   
path = "../aws-runtime"
 2083   2439   
version = "1.5.9"
 2084   2440   
 2085   2441   
[dependencies.aws-sigv4]
 2086   2442   
path = "../aws-sigv4"
 2087         -
version = "1.3.3"
        2443  +
version = "1.3.4"
 2088   2444   
 2089   2445   
[dependencies.aws-smithy-async]
 2090   2446   
path = "../aws-smithy-async"
 2091   2447   
version = "1.2.5"
 2092   2448   
 2093   2449   
[dependencies.aws-smithy-http]
 2094   2450   
path = "../aws-smithy-http"
 2095         -
version = "0.62.2"
        2451  +
version = "0.62.3"
 2096   2452   
 2097   2453   
[dependencies.aws-smithy-json]
 2098   2454   
path = "../aws-smithy-json"
 2099   2455   
version = "0.61.4"
 2100   2456   
 2101   2457   
[dependencies.aws-smithy-runtime]
 2102   2458   
path = "../aws-smithy-runtime"
 2103   2459   
features = ["client"]
 2104   2460   
version = "1.8.5"
 2105   2461   
 2106   2462   
[dependencies.aws-smithy-runtime-api]
 2107   2463   
path = "../aws-smithy-runtime-api"
 2108   2464   
features = ["client", "http-02x"]
 2109   2465   
version = "1.8.5"
 2110   2466   
 2111   2467   
[dependencies.aws-smithy-types]
 2112   2468   
path = "../aws-smithy-types"
 2113   2469   
version = "1.3.2"
 2114   2470   
 2115   2471   
[dependencies.aws-types]
 2116   2472   
path = "../aws-types"
 2117   2473   
version = "1.3.8"
 2118   2474   
 2119   2475   
[dependencies.bytes]
 2120   2476   
version = "1.4.0"
 2121   2477   
 2122   2478   
[dependencies.fastrand]
 2123   2479   
version = "2.0.0"
 2124   2480   
 2125   2481   
[dependencies.hex]
 2126   2482   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/iam/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/iam/Cargo.toml
 2127   2483   
index d718a3a..65e6f24 100644
 2128         -
-- a/tmp-codegen-diff/aws-sdk/sdk/iam/Cargo.toml
        2484  +
++ b/tmp-codegen-diff/aws-sdk/sdk/iam/Cargo.toml
 2129   2485   
@@ -1,61 +1,61 @@
 2130   2486   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2131   2487   
[package]
 2132   2488   
name = "aws-sdk-iam"
 2133   2489   
version = "0.0.0-local"
 2134   2490   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2135   2491   
description = "AWS SDK for AWS Identity and Access Management"
 2136   2492   
edition = "2021"
 2137   2493   
license = "Apache-2.0"
 2138   2494   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2139   2495   
rust-version = "1.86.0"
 2140   2496   
readme = "README.md"
 2141   2497   
[package.metadata.smithy]
 2142   2498   
codegen-version = "ci"
 2143   2499   
[package.metadata.docs.rs]
 2144   2500   
all-features = true
 2145   2501   
targets = ["x86_64-unknown-linux-gnu"]
 2146   2502   
[dependencies.aws-credential-types]
 2147   2503   
path = "../aws-credential-types"
 2148   2504   
version = "1.2.4"
 2149   2505   
 2150   2506   
[dependencies.aws-runtime]
 2151   2507   
path = "../aws-runtime"
 2152   2508   
version = "1.5.9"
 2153   2509   
 2154   2510   
[dependencies.aws-smithy-async]
 2155   2511   
path = "../aws-smithy-async"
 2156   2512   
version = "1.2.5"
 2157   2513   
 2158   2514   
[dependencies.aws-smithy-http]
 2159   2515   
path = "../aws-smithy-http"
 2160         -
version = "0.62.2"
        2516  +
version = "0.62.3"
 2161   2517   
 2162   2518   
[dependencies.aws-smithy-json]
 2163   2519   
path = "../aws-smithy-json"
 2164   2520   
version = "0.61.4"
 2165   2521   
 2166   2522   
[dependencies.aws-smithy-query]
 2167   2523   
path = "../aws-smithy-query"
 2168   2524   
version = "0.60.7"
 2169   2525   
 2170   2526   
[dependencies.aws-smithy-runtime]
 2171   2527   
path = "../aws-smithy-runtime"
 2172   2528   
features = ["client"]
 2173   2529   
version = "1.8.5"
 2174   2530   
 2175   2531   
[dependencies.aws-smithy-runtime-api]
 2176   2532   
path = "../aws-smithy-runtime-api"
 2177   2533   
features = ["client", "http-02x"]
 2178   2534   
version = "1.8.5"
 2179   2535   
 2180   2536   
[dependencies.aws-smithy-types]
 2181   2537   
path = "../aws-smithy-types"
 2182   2538   
version = "1.3.2"
 2183   2539   
 2184   2540   
[dependencies.aws-smithy-xml]
 2185   2541   
path = "../aws-smithy-xml"
 2186   2542   
version = "0.60.10"
 2187   2543   
 2188   2544   
[dependencies.aws-types]
 2189   2545   
path = "../aws-types"
 2190   2546   
version = "1.3.8"
 2191   2547   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/kms/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/kms/Cargo.toml
 2192   2548   
index 0ed4302..3d828a5 100644
 2193         -
-- a/tmp-codegen-diff/aws-sdk/sdk/kms/Cargo.toml
        2549  +
++ b/tmp-codegen-diff/aws-sdk/sdk/kms/Cargo.toml
 2194   2550   
@@ -1,61 +1,61 @@
 2195   2551   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2196   2552   
[package]
 2197   2553   
name = "aws-sdk-kms"
 2198   2554   
version = "0.0.0-local"
 2199   2555   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2200   2556   
description = "AWS SDK for AWS Key Management Service"
 2201   2557   
edition = "2021"
 2202   2558   
license = "Apache-2.0"
 2203   2559   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2204   2560   
rust-version = "1.86.0"
 2205   2561   
readme = "README.md"
 2206   2562   
[package.metadata.smithy]
 2207   2563   
codegen-version = "ci"
 2208   2564   
[package.metadata.docs.rs]
 2209   2565   
all-features = true
 2210   2566   
targets = ["x86_64-unknown-linux-gnu"]
 2211   2567   
[dependencies.aws-credential-types]
 2212   2568   
path = "../aws-credential-types"
 2213   2569   
version = "1.2.4"
 2214   2570   
 2215   2571   
[dependencies.aws-runtime]
 2216   2572   
path = "../aws-runtime"
 2217   2573   
version = "1.5.9"
 2218   2574   
 2219   2575   
[dependencies.aws-smithy-async]
 2220   2576   
path = "../aws-smithy-async"
 2221   2577   
version = "1.2.5"
 2222   2578   
 2223   2579   
[dependencies.aws-smithy-http]
 2224   2580   
path = "../aws-smithy-http"
 2225         -
version = "0.62.2"
        2581  +
version = "0.62.3"
 2226   2582   
 2227   2583   
[dependencies.aws-smithy-json]
 2228   2584   
path = "../aws-smithy-json"
 2229   2585   
version = "0.61.4"
 2230   2586   
 2231   2587   
[dependencies.aws-smithy-runtime]
 2232   2588   
path = "../aws-smithy-runtime"
 2233   2589   
features = ["client"]
 2234   2590   
version = "1.8.5"
 2235   2591   
 2236   2592   
[dependencies.aws-smithy-runtime-api]
 2237   2593   
path = "../aws-smithy-runtime-api"
 2238   2594   
features = ["client", "http-02x"]
 2239   2595   
version = "1.8.5"
 2240   2596   
 2241   2597   
[dependencies.aws-smithy-types]
 2242   2598   
path = "../aws-smithy-types"
 2243   2599   
version = "1.3.2"
 2244   2600   
 2245   2601   
[dependencies.aws-types]
 2246   2602   
path = "../aws-types"
 2247   2603   
version = "1.3.8"
 2248   2604   
 2249   2605   
[dependencies.bytes]
 2250   2606   
version = "1.4.0"
 2251   2607   
 2252   2608   
[dependencies.fastrand]
 2253   2609   
version = "2.0.0"
 2254   2610   
 2255   2611   
[dependencies.http]
 2256   2612   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/lambda/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/lambda/Cargo.toml
 2257   2613   
index 6518dfc..6b94752 100644
 2258         -
-- a/tmp-codegen-diff/aws-sdk/sdk/lambda/Cargo.toml
        2614  +
++ b/tmp-codegen-diff/aws-sdk/sdk/lambda/Cargo.toml
 2259   2615   
@@ -7,61 +7,61 @@ description = "AWS SDK for AWS Lambda"
 2260   2616   
edition = "2021"
 2261   2617   
license = "Apache-2.0"
 2262   2618   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2263   2619   
rust-version = "1.86.0"
 2264   2620   
readme = "README.md"
 2265   2621   
[package.metadata.smithy]
 2266   2622   
codegen-version = "ci"
 2267   2623   
[package.metadata.docs.rs]
 2268   2624   
all-features = true
 2269   2625   
targets = ["x86_64-unknown-linux-gnu"]
 2270   2626   
[dependencies.aws-credential-types]
 2271   2627   
path = "../aws-credential-types"
 2272   2628   
version = "1.2.4"
 2273   2629   
 2274   2630   
[dependencies.aws-runtime]
 2275   2631   
path = "../aws-runtime"
 2276   2632   
features = ["event-stream"]
 2277   2633   
version = "1.5.9"
 2278   2634   
 2279   2635   
[dependencies.aws-smithy-async]
 2280   2636   
path = "../aws-smithy-async"
 2281   2637   
version = "1.2.5"
 2282   2638   
 2283   2639   
[dependencies.aws-smithy-eventstream]
 2284   2640   
path = "../aws-smithy-eventstream"
 2285   2641   
version = "0.60.10"
 2286   2642   
 2287   2643   
[dependencies.aws-smithy-http]
 2288   2644   
path = "../aws-smithy-http"
 2289   2645   
features = ["event-stream"]
 2290         -
version = "0.62.2"
        2646  +
version = "0.62.3"
 2291   2647   
 2292   2648   
[dependencies.aws-smithy-json]
 2293   2649   
path = "../aws-smithy-json"
 2294   2650   
version = "0.61.4"
 2295   2651   
 2296   2652   
[dependencies.aws-smithy-runtime]
 2297   2653   
path = "../aws-smithy-runtime"
 2298   2654   
features = ["client"]
 2299   2655   
version = "1.8.5"
 2300   2656   
 2301   2657   
[dependencies.aws-smithy-runtime-api]
 2302   2658   
path = "../aws-smithy-runtime-api"
 2303   2659   
features = ["client", "http-02x"]
 2304   2660   
version = "1.8.5"
 2305   2661   
 2306   2662   
[dependencies.aws-smithy-types]
 2307   2663   
path = "../aws-smithy-types"
 2308   2664   
version = "1.3.2"
 2309   2665   
 2310   2666   
[dependencies.aws-types]
 2311   2667   
path = "../aws-types"
 2312   2668   
version = "1.3.8"
 2313   2669   
 2314   2670   
[dependencies.bytes]
 2315   2671   
version = "1.4.0"
 2316   2672   
 2317   2673   
[dependencies.fastrand]
 2318   2674   
version = "2.0.0"
 2319   2675   
 2320   2676   
[dependencies.http]
 2321   2677   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/polly/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/polly/Cargo.toml
 2322   2678   
index dabb0e0..34cbc15 100644
 2323         -
-- a/tmp-codegen-diff/aws-sdk/sdk/polly/Cargo.toml
        2679  +
++ b/tmp-codegen-diff/aws-sdk/sdk/polly/Cargo.toml
 2324   2680   
@@ -1,65 +1,65 @@
 2325   2681   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2326   2682   
[package]
 2327   2683   
name = "aws-sdk-polly"
 2328   2684   
version = "0.0.0-local"
 2329   2685   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2330   2686   
description = "AWS SDK for Amazon Polly"
 2331   2687   
edition = "2021"
 2332   2688   
license = "Apache-2.0"
 2333   2689   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2334   2690   
rust-version = "1.86.0"
 2335   2691   
readme = "README.md"
 2336   2692   
[package.metadata.smithy]
 2337   2693   
codegen-version = "ci"
 2338   2694   
[package.metadata.docs.rs]
 2339   2695   
all-features = true
 2340   2696   
targets = ["x86_64-unknown-linux-gnu"]
 2341   2697   
[dependencies.aws-credential-types]
 2342   2698   
path = "../aws-credential-types"
 2343   2699   
version = "1.2.4"
 2344   2700   
 2345   2701   
[dependencies.aws-runtime]
 2346   2702   
path = "../aws-runtime"
 2347   2703   
version = "1.5.9"
 2348   2704   
 2349   2705   
[dependencies.aws-sigv4]
 2350   2706   
path = "../aws-sigv4"
 2351         -
version = "1.3.3"
        2707  +
version = "1.3.4"
 2352   2708   
 2353   2709   
[dependencies.aws-smithy-async]
 2354   2710   
path = "../aws-smithy-async"
 2355   2711   
version = "1.2.5"
 2356   2712   
 2357   2713   
[dependencies.aws-smithy-http]
 2358   2714   
path = "../aws-smithy-http"
 2359         -
version = "0.62.2"
        2715  +
version = "0.62.3"
 2360   2716   
 2361   2717   
[dependencies.aws-smithy-json]
 2362   2718   
path = "../aws-smithy-json"
 2363   2719   
version = "0.61.4"
 2364   2720   
 2365   2721   
[dependencies.aws-smithy-runtime]
 2366   2722   
path = "../aws-smithy-runtime"
 2367   2723   
features = ["client"]
 2368   2724   
version = "1.8.5"
 2369   2725   
 2370   2726   
[dependencies.aws-smithy-runtime-api]
 2371   2727   
path = "../aws-smithy-runtime-api"
 2372   2728   
features = ["client", "http-02x"]
 2373   2729   
version = "1.8.5"
 2374   2730   
 2375   2731   
[dependencies.aws-smithy-types]
 2376   2732   
path = "../aws-smithy-types"
 2377   2733   
version = "1.3.2"
 2378   2734   
 2379   2735   
[dependencies.aws-types]
 2380   2736   
path = "../aws-types"
 2381   2737   
version = "1.3.8"
 2382   2738   
 2383   2739   
[dependencies.bytes]
 2384   2740   
version = "1.4.0"
 2385   2741   
 2386   2742   
[dependencies.fastrand]
 2387   2743   
version = "2.0.0"
 2388   2744   
 2389   2745   
[dependencies.http]
 2390   2746   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/qldbsession/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/qldbsession/Cargo.toml
 2391   2747   
index a884716..f3d8713 100644
 2392         -
-- a/tmp-codegen-diff/aws-sdk/sdk/qldbsession/Cargo.toml
        2748  +
++ b/tmp-codegen-diff/aws-sdk/sdk/qldbsession/Cargo.toml
 2393   2749   
@@ -1,61 +1,61 @@
 2394   2750   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2395   2751   
[package]
 2396   2752   
name = "aws-sdk-qldbsession"
 2397   2753   
version = "0.0.0-local"
 2398   2754   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2399   2755   
description = "AWS SDK for Amazon QLDB Session"
 2400   2756   
edition = "2021"
 2401   2757   
license = "Apache-2.0"
 2402   2758   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2403   2759   
rust-version = "1.86.0"
 2404   2760   
readme = "README.md"
 2405   2761   
[package.metadata.smithy]
 2406   2762   
codegen-version = "ci"
 2407   2763   
[package.metadata.docs.rs]
 2408   2764   
all-features = true
 2409   2765   
targets = ["x86_64-unknown-linux-gnu"]
 2410   2766   
[dependencies.aws-credential-types]
 2411   2767   
path = "../aws-credential-types"
 2412   2768   
version = "1.2.4"
 2413   2769   
 2414   2770   
[dependencies.aws-runtime]
 2415   2771   
path = "../aws-runtime"
 2416   2772   
version = "1.5.9"
 2417   2773   
 2418   2774   
[dependencies.aws-smithy-async]
 2419   2775   
path = "../aws-smithy-async"
 2420   2776   
version = "1.2.5"
 2421   2777   
 2422   2778   
[dependencies.aws-smithy-http]
 2423   2779   
path = "../aws-smithy-http"
 2424         -
version = "0.62.2"
        2780  +
version = "0.62.3"
 2425   2781   
 2426   2782   
[dependencies.aws-smithy-json]
 2427   2783   
path = "../aws-smithy-json"
 2428   2784   
version = "0.61.4"
 2429   2785   
 2430   2786   
[dependencies.aws-smithy-runtime]
 2431   2787   
path = "../aws-smithy-runtime"
 2432   2788   
features = ["client"]
 2433   2789   
version = "1.8.5"
 2434   2790   
 2435   2791   
[dependencies.aws-smithy-runtime-api]
 2436   2792   
path = "../aws-smithy-runtime-api"
 2437   2793   
features = ["client", "http-02x"]
 2438   2794   
version = "1.8.5"
 2439   2795   
 2440   2796   
[dependencies.aws-smithy-types]
 2441   2797   
path = "../aws-smithy-types"
 2442   2798   
version = "1.3.2"
 2443   2799   
 2444   2800   
[dependencies.aws-types]
 2445   2801   
path = "../aws-types"
 2446   2802   
version = "1.3.8"
 2447   2803   
 2448   2804   
[dependencies.bytes]
 2449   2805   
version = "1.4.0"
 2450   2806   
 2451   2807   
[dependencies.fastrand]
 2452   2808   
version = "2.0.0"
 2453   2809   
 2454   2810   
[dependencies.http]
 2455   2811   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/route53/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/route53/Cargo.toml
 2456   2812   
index 32a7dc9..a2c752d 100644
 2457         -
-- a/tmp-codegen-diff/aws-sdk/sdk/route53/Cargo.toml
        2813  +
++ b/tmp-codegen-diff/aws-sdk/sdk/route53/Cargo.toml
 2458   2814   
@@ -1,61 +1,61 @@
 2459   2815   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2460   2816   
[package]
 2461   2817   
name = "aws-sdk-route53"
 2462   2818   
version = "0.0.0-local"
 2463   2819   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2464   2820   
description = "AWS SDK for Amazon Route 53"
 2465   2821   
edition = "2021"
 2466   2822   
license = "Apache-2.0"
 2467   2823   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2468   2824   
rust-version = "1.86.0"
 2469   2825   
readme = "README.md"
 2470   2826   
[package.metadata.smithy]
 2471   2827   
codegen-version = "ci"
 2472   2828   
[package.metadata.docs.rs]
 2473   2829   
all-features = true
 2474   2830   
targets = ["x86_64-unknown-linux-gnu"]
 2475   2831   
[dependencies.aws-credential-types]
 2476   2832   
path = "../aws-credential-types"
 2477   2833   
version = "1.2.4"
 2478   2834   
 2479   2835   
[dependencies.aws-runtime]
 2480   2836   
path = "../aws-runtime"
 2481   2837   
version = "1.5.9"
 2482   2838   
 2483   2839   
[dependencies.aws-smithy-async]
 2484   2840   
path = "../aws-smithy-async"
 2485   2841   
version = "1.2.5"
 2486   2842   
 2487   2843   
[dependencies.aws-smithy-http]
 2488   2844   
path = "../aws-smithy-http"
 2489         -
version = "0.62.2"
        2845  +
version = "0.62.3"
 2490   2846   
 2491   2847   
[dependencies.aws-smithy-json]
 2492   2848   
path = "../aws-smithy-json"
 2493   2849   
version = "0.61.4"
 2494   2850   
 2495   2851   
[dependencies.aws-smithy-runtime]
 2496   2852   
path = "../aws-smithy-runtime"
 2497   2853   
features = ["client"]
 2498   2854   
version = "1.8.5"
 2499   2855   
 2500   2856   
[dependencies.aws-smithy-runtime-api]
 2501   2857   
path = "../aws-smithy-runtime-api"
 2502   2858   
features = ["client", "http-02x"]
 2503   2859   
version = "1.8.5"
 2504   2860   
 2505   2861   
[dependencies.aws-smithy-types]
 2506   2862   
path = "../aws-smithy-types"
 2507   2863   
version = "1.3.2"
 2508   2864   
 2509   2865   
[dependencies.aws-smithy-xml]
 2510   2866   
path = "../aws-smithy-xml"
 2511   2867   
version = "0.60.10"
 2512   2868   
 2513   2869   
[dependencies.aws-types]
 2514   2870   
path = "../aws-types"
 2515   2871   
version = "1.3.8"
 2516   2872   
 2517   2873   
[dependencies.fastrand]
 2518   2874   
version = "2.0.0"
 2519   2875   
 2520   2876   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/s3/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/s3/Cargo.toml
 2521   2877   
index f65e261..2f6bec0 100644
 2522         -
-- a/tmp-codegen-diff/aws-sdk/sdk/s3/Cargo.toml
        2878  +
++ b/tmp-codegen-diff/aws-sdk/sdk/s3/Cargo.toml
 2523   2879   
@@ -1,75 +1,75 @@
 2524   2880   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2525   2881   
[package]
 2526   2882   
name = "aws-sdk-s3"
 2527   2883   
version = "0.0.0-local"
 2528   2884   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2529   2885   
description = "AWS SDK for Amazon Simple Storage Service"
 2530   2886   
edition = "2021"
 2531   2887   
license = "Apache-2.0"
 2532   2888   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2533   2889   
rust-version = "1.86.0"
 2534   2890   
readme = "README.md"
 2535   2891   
[package.metadata.smithy]
 2536   2892   
codegen-version = "ci"
 2537   2893   
[package.metadata.docs.rs]
 2538   2894   
all-features = true
 2539   2895   
targets = ["x86_64-unknown-linux-gnu"]
 2540   2896   
[dependencies.aws-credential-types]
 2541   2897   
path = "../aws-credential-types"
 2542   2898   
version = "1.2.4"
 2543   2899   
 2544   2900   
[dependencies.aws-runtime]
 2545   2901   
path = "../aws-runtime"
 2546   2902   
features = ["event-stream", "http-02x"]
 2547   2903   
version = "1.5.9"
 2548   2904   
 2549   2905   
[dependencies.aws-sigv4]
 2550   2906   
path = "../aws-sigv4"
 2551         -
version = "1.3.3"
        2907  +
version = "1.3.4"
 2552   2908   
 2553   2909   
[dependencies.aws-smithy-async]
 2554   2910   
path = "../aws-smithy-async"
 2555   2911   
version = "1.2.5"
 2556   2912   
 2557   2913   
[dependencies.aws-smithy-checksums]
 2558   2914   
path = "../aws-smithy-checksums"
 2559   2915   
version = "0.63.5"
 2560   2916   
 2561   2917   
[dependencies.aws-smithy-eventstream]
 2562   2918   
path = "../aws-smithy-eventstream"
 2563   2919   
version = "0.60.10"
 2564   2920   
 2565   2921   
[dependencies.aws-smithy-http]
 2566   2922   
path = "../aws-smithy-http"
 2567   2923   
features = ["event-stream"]
 2568         -
version = "0.62.2"
        2924  +
version = "0.62.3"
 2569   2925   
 2570   2926   
[dependencies.aws-smithy-json]
 2571   2927   
path = "../aws-smithy-json"
 2572   2928   
version = "0.61.4"
 2573   2929   
 2574   2930   
[dependencies.aws-smithy-runtime]
 2575   2931   
path = "../aws-smithy-runtime"
 2576   2932   
features = ["client"]
 2577   2933   
version = "1.8.5"
 2578   2934   
 2579   2935   
[dependencies.aws-smithy-runtime-api]
 2580   2936   
path = "../aws-smithy-runtime-api"
 2581   2937   
features = ["client", "http-02x"]
 2582   2938   
version = "1.8.5"
 2583   2939   
 2584   2940   
[dependencies.aws-smithy-types]
 2585   2941   
path = "../aws-smithy-types"
 2586   2942   
version = "1.3.2"
 2587   2943   
 2588   2944   
[dependencies.aws-smithy-xml]
 2589   2945   
path = "../aws-smithy-xml"
 2590   2946   
version = "0.60.10"
 2591   2947   
 2592   2948   
[dependencies.aws-types]
 2593   2949   
path = "../aws-types"
 2594   2950   
version = "1.3.8"
 2595   2951   
 2596   2952   
[dependencies.bytes]
 2597   2953   
version = "1.4.0"
 2598   2954   
 2599   2955   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/s3control/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/s3control/Cargo.toml
 2600   2956   
index b4d1cdd..861c0cc 100644
 2601         -
-- a/tmp-codegen-diff/aws-sdk/sdk/s3control/Cargo.toml
        2957  +
++ b/tmp-codegen-diff/aws-sdk/sdk/s3control/Cargo.toml
 2602   2958   
@@ -1,61 +1,61 @@
 2603   2959   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2604   2960   
[package]
 2605   2961   
name = "aws-sdk-s3control"
 2606   2962   
version = "0.0.0-local"
 2607   2963   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2608   2964   
description = "AWS SDK for AWS S3 Control"
 2609   2965   
edition = "2021"
 2610   2966   
license = "Apache-2.0"
 2611   2967   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2612   2968   
rust-version = "1.86.0"
 2613   2969   
readme = "README.md"
 2614   2970   
[package.metadata.smithy]
 2615   2971   
codegen-version = "ci"
 2616   2972   
[package.metadata.docs.rs]
 2617   2973   
all-features = true
 2618   2974   
targets = ["x86_64-unknown-linux-gnu"]
 2619   2975   
[dependencies.aws-credential-types]
 2620   2976   
path = "../aws-credential-types"
 2621   2977   
version = "1.2.4"
 2622   2978   
 2623   2979   
[dependencies.aws-runtime]
 2624   2980   
path = "../aws-runtime"
 2625   2981   
version = "1.5.9"
 2626   2982   
 2627   2983   
[dependencies.aws-smithy-async]
 2628   2984   
path = "../aws-smithy-async"
 2629   2985   
version = "1.2.5"
 2630   2986   
 2631   2987   
[dependencies.aws-smithy-http]
 2632   2988   
path = "../aws-smithy-http"
 2633         -
version = "0.62.2"
        2989  +
version = "0.62.3"
 2634   2990   
 2635   2991   
[dependencies.aws-smithy-json]
 2636   2992   
path = "../aws-smithy-json"
 2637   2993   
version = "0.61.4"
 2638   2994   
 2639   2995   
[dependencies.aws-smithy-runtime]
 2640   2996   
path = "../aws-smithy-runtime"
 2641   2997   
features = ["client"]
 2642   2998   
version = "1.8.5"
 2643   2999   
 2644   3000   
[dependencies.aws-smithy-runtime-api]
 2645   3001   
path = "../aws-smithy-runtime-api"
 2646   3002   
features = ["client", "http-02x"]
 2647   3003   
version = "1.8.5"
 2648   3004   
 2649   3005   
[dependencies.aws-smithy-types]
 2650   3006   
path = "../aws-smithy-types"
 2651   3007   
version = "1.3.2"
 2652   3008   
 2653   3009   
[dependencies.aws-smithy-xml]
 2654   3010   
path = "../aws-smithy-xml"
 2655   3011   
version = "0.60.10"
 2656   3012   
 2657   3013   
[dependencies.aws-types]
 2658   3014   
path = "../aws-types"
 2659   3015   
version = "1.3.8"
 2660   3016   
 2661   3017   
[dependencies.fastrand]
 2662   3018   
version = "2.0.0"
 2663   3019   
 2664   3020   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/sso/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/sso/Cargo.toml
 2665   3021   
index 2cde182..fc367f4 100644
 2666         -
-- a/tmp-codegen-diff/aws-sdk/sdk/sso/Cargo.toml
        3022  +
++ b/tmp-codegen-diff/aws-sdk/sdk/sso/Cargo.toml
 2667   3023   
@@ -1,61 +1,61 @@
 2668   3024   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2669   3025   
[package]
 2670   3026   
name = "aws-sdk-sso"
 2671   3027   
version = "0.0.0-local"
 2672   3028   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2673   3029   
description = "AWS SDK for AWS Single Sign-On"
 2674   3030   
edition = "2021"
 2675   3031   
license = "Apache-2.0"
 2676   3032   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2677   3033   
rust-version = "1.86.0"
 2678   3034   
readme = "README.md"
 2679   3035   
[package.metadata.smithy]
 2680   3036   
codegen-version = "ci"
 2681   3037   
[package.metadata.docs.rs]
 2682   3038   
all-features = true
 2683   3039   
targets = ["x86_64-unknown-linux-gnu"]
 2684   3040   
[dependencies.aws-credential-types]
 2685   3041   
path = "../aws-credential-types"
 2686   3042   
version = "1.2.4"
 2687   3043   
 2688   3044   
[dependencies.aws-runtime]
 2689   3045   
path = "../aws-runtime"
 2690   3046   
version = "1.5.9"
 2691   3047   
 2692   3048   
[dependencies.aws-smithy-async]
 2693   3049   
path = "../aws-smithy-async"
 2694   3050   
version = "1.2.5"
 2695   3051   
 2696   3052   
[dependencies.aws-smithy-http]
 2697   3053   
path = "../aws-smithy-http"
 2698         -
version = "0.62.2"
        3054  +
version = "0.62.3"
 2699   3055   
 2700   3056   
[dependencies.aws-smithy-json]
 2701   3057   
path = "../aws-smithy-json"
 2702   3058   
version = "0.61.4"
 2703   3059   
 2704   3060   
[dependencies.aws-smithy-runtime]
 2705   3061   
path = "../aws-smithy-runtime"
 2706   3062   
features = ["client"]
 2707   3063   
version = "1.8.5"
 2708   3064   
 2709   3065   
[dependencies.aws-smithy-runtime-api]
 2710   3066   
path = "../aws-smithy-runtime-api"
 2711   3067   
features = ["client", "http-02x"]
 2712   3068   
version = "1.8.5"
 2713   3069   
 2714   3070   
[dependencies.aws-smithy-types]
 2715   3071   
path = "../aws-smithy-types"
 2716   3072   
version = "1.3.2"
 2717   3073   
 2718   3074   
[dependencies.aws-types]
 2719   3075   
path = "../aws-types"
 2720   3076   
version = "1.3.8"
 2721   3077   
 2722   3078   
[dependencies.bytes]
 2723   3079   
version = "1.4.0"
 2724   3080   
 2725   3081   
[dependencies.fastrand]
 2726   3082   
version = "2.0.0"
 2727   3083   
 2728   3084   
[dependencies.http]
 2729   3085   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/ssooidc/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/ssooidc/Cargo.toml
 2730   3086   
index 7a34c16..588d0bd 100644
 2731         -
-- a/tmp-codegen-diff/aws-sdk/sdk/ssooidc/Cargo.toml
        3087  +
++ b/tmp-codegen-diff/aws-sdk/sdk/ssooidc/Cargo.toml
 2732   3088   
@@ -1,61 +1,61 @@
 2733   3089   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2734   3090   
[package]
 2735   3091   
name = "aws-sdk-ssooidc"
 2736   3092   
version = "0.0.0-local"
 2737   3093   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2738   3094   
description = "AWS SDK for AWS SSO OIDC"
 2739   3095   
edition = "2021"
 2740   3096   
license = "Apache-2.0"
 2741   3097   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2742   3098   
rust-version = "1.86.0"
 2743   3099   
readme = "README.md"
 2744   3100   
[package.metadata.smithy]
 2745   3101   
codegen-version = "ci"
 2746   3102   
[package.metadata.docs.rs]
 2747   3103   
all-features = true
 2748   3104   
targets = ["x86_64-unknown-linux-gnu"]
 2749   3105   
[dependencies.aws-credential-types]
 2750   3106   
path = "../aws-credential-types"
 2751   3107   
version = "1.2.4"
 2752   3108   
 2753   3109   
[dependencies.aws-runtime]
 2754   3110   
path = "../aws-runtime"
 2755   3111   
version = "1.5.9"
 2756   3112   
 2757   3113   
[dependencies.aws-smithy-async]
 2758   3114   
path = "../aws-smithy-async"
 2759   3115   
version = "1.2.5"
 2760   3116   
 2761   3117   
[dependencies.aws-smithy-http]
 2762   3118   
path = "../aws-smithy-http"
 2763         -
version = "0.62.2"
        3119  +
version = "0.62.3"
 2764   3120   
 2765   3121   
[dependencies.aws-smithy-json]
 2766   3122   
path = "../aws-smithy-json"
 2767   3123   
version = "0.61.4"
 2768   3124   
 2769   3125   
[dependencies.aws-smithy-runtime]
 2770   3126   
path = "../aws-smithy-runtime"
 2771   3127   
features = ["client"]
 2772   3128   
version = "1.8.5"
 2773   3129   
 2774   3130   
[dependencies.aws-smithy-runtime-api]
 2775   3131   
path = "../aws-smithy-runtime-api"
 2776   3132   
features = ["client", "http-02x"]
 2777   3133   
version = "1.8.5"
 2778   3134   
 2779   3135   
[dependencies.aws-smithy-types]
 2780   3136   
path = "../aws-smithy-types"
 2781   3137   
version = "1.3.2"
 2782   3138   
 2783   3139   
[dependencies.aws-types]
 2784   3140   
path = "../aws-types"
 2785   3141   
version = "1.3.8"
 2786   3142   
 2787   3143   
[dependencies.bytes]
 2788   3144   
version = "1.4.0"
 2789   3145   
 2790   3146   
[dependencies.fastrand]
 2791   3147   
version = "2.0.0"
 2792   3148   
 2793   3149   
[dependencies.http]
 2794   3150   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/sts/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/sts/Cargo.toml
 2795   3151   
index 895dfb3..f2ce34e 100644
 2796         -
-- a/tmp-codegen-diff/aws-sdk/sdk/sts/Cargo.toml
        3152  +
++ b/tmp-codegen-diff/aws-sdk/sdk/sts/Cargo.toml
 2797   3153   
@@ -1,61 +1,61 @@
 2798   3154   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2799   3155   
[package]
 2800   3156   
name = "aws-sdk-sts"
 2801   3157   
version = "0.0.0-local"
 2802   3158   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2803   3159   
description = "AWS SDK for AWS Security Token Service"
 2804   3160   
edition = "2021"
 2805   3161   
license = "Apache-2.0"
 2806   3162   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2807   3163   
rust-version = "1.86.0"
 2808   3164   
readme = "README.md"
 2809   3165   
[package.metadata.smithy]
 2810   3166   
codegen-version = "ci"
 2811   3167   
[package.metadata.docs.rs]
 2812   3168   
all-features = true
 2813   3169   
targets = ["x86_64-unknown-linux-gnu"]
 2814   3170   
[dependencies.aws-credential-types]
 2815   3171   
path = "../aws-credential-types"
 2816   3172   
version = "1.2.4"
 2817   3173   
 2818   3174   
[dependencies.aws-runtime]
 2819   3175   
path = "../aws-runtime"
 2820   3176   
version = "1.5.9"
 2821   3177   
 2822   3178   
[dependencies.aws-smithy-async]
 2823   3179   
path = "../aws-smithy-async"
 2824   3180   
version = "1.2.5"
 2825   3181   
 2826   3182   
[dependencies.aws-smithy-http]
 2827   3183   
path = "../aws-smithy-http"
 2828         -
version = "0.62.2"
        3184  +
version = "0.62.3"
 2829   3185   
 2830   3186   
[dependencies.aws-smithy-json]
 2831   3187   
path = "../aws-smithy-json"
 2832   3188   
version = "0.61.4"
 2833   3189   
 2834   3190   
[dependencies.aws-smithy-query]
 2835   3191   
path = "../aws-smithy-query"
 2836   3192   
version = "0.60.7"
 2837   3193   
 2838   3194   
[dependencies.aws-smithy-runtime]
 2839   3195   
path = "../aws-smithy-runtime"
 2840   3196   
features = ["client"]
 2841   3197   
version = "1.8.5"
 2842   3198   
 2843   3199   
[dependencies.aws-smithy-runtime-api]
 2844   3200   
path = "../aws-smithy-runtime-api"
 2845   3201   
features = ["client", "http-02x"]
 2846   3202   
version = "1.8.5"
 2847   3203   
 2848   3204   
[dependencies.aws-smithy-types]
 2849   3205   
path = "../aws-smithy-types"
 2850   3206   
version = "1.3.2"
 2851   3207   
 2852   3208   
[dependencies.aws-smithy-xml]
 2853   3209   
path = "../aws-smithy-xml"
 2854   3210   
version = "0.60.10"
 2855   3211   
 2856   3212   
[dependencies.aws-types]
 2857   3213   
path = "../aws-types"
 2858   3214   
version = "1.3.8"
 2859   3215   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/timestreamquery/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/timestreamquery/Cargo.toml
 2860   3216   
index d556561..91178b6 100644
 2861         -
-- a/tmp-codegen-diff/aws-sdk/sdk/timestreamquery/Cargo.toml
        3217  +
++ b/tmp-codegen-diff/aws-sdk/sdk/timestreamquery/Cargo.toml
 2862   3218   
@@ -1,61 +1,61 @@
 2863   3219   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2864   3220   
[package]
 2865   3221   
name = "aws-sdk-timestreamquery"
 2866   3222   
version = "0.0.0-local"
 2867   3223   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2868   3224   
description = "AWS SDK for Amazon Timestream Query"
 2869   3225   
edition = "2021"
 2870   3226   
license = "Apache-2.0"
 2871   3227   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2872   3228   
rust-version = "1.86.0"
 2873   3229   
readme = "README.md"
 2874   3230   
[package.metadata.smithy]
 2875   3231   
codegen-version = "ci"
 2876   3232   
[package.metadata.docs.rs]
 2877   3233   
all-features = true
 2878   3234   
targets = ["x86_64-unknown-linux-gnu"]
 2879   3235   
[dependencies.aws-credential-types]
 2880   3236   
path = "../aws-credential-types"
 2881   3237   
version = "1.2.4"
 2882   3238   
 2883   3239   
[dependencies.aws-runtime]
 2884   3240   
path = "../aws-runtime"
 2885   3241   
version = "1.5.9"
 2886   3242   
 2887   3243   
[dependencies.aws-smithy-async]
 2888   3244   
path = "../aws-smithy-async"
 2889   3245   
version = "1.2.5"
 2890   3246   
 2891   3247   
[dependencies.aws-smithy-http]
 2892   3248   
path = "../aws-smithy-http"
 2893         -
version = "0.62.2"
        3249  +
version = "0.62.3"
 2894   3250   
 2895   3251   
[dependencies.aws-smithy-json]
 2896   3252   
path = "../aws-smithy-json"
 2897   3253   
version = "0.61.4"
 2898   3254   
 2899   3255   
[dependencies.aws-smithy-runtime]
 2900   3256   
path = "../aws-smithy-runtime"
 2901   3257   
features = ["client"]
 2902   3258   
version = "1.8.5"
 2903   3259   
 2904   3260   
[dependencies.aws-smithy-runtime-api]
 2905   3261   
path = "../aws-smithy-runtime-api"
 2906   3262   
features = ["client", "http-02x"]
 2907   3263   
version = "1.8.5"
 2908   3264   
 2909   3265   
[dependencies.aws-smithy-types]
 2910   3266   
path = "../aws-smithy-types"
 2911   3267   
version = "1.3.2"
 2912   3268   
 2913   3269   
[dependencies.aws-types]
 2914   3270   
path = "../aws-types"
 2915   3271   
version = "1.3.8"
 2916   3272   
 2917   3273   
[dependencies.bytes]
 2918   3274   
version = "1.4.0"
 2919   3275   
 2920   3276   
[dependencies.fastrand]
 2921   3277   
version = "2.0.0"
 2922   3278   
 2923   3279   
[dependencies.http]
 2924   3280   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/timestreamwrite/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/timestreamwrite/Cargo.toml
 2925   3281   
index 0c56e4c..95731e3 100644
 2926         -
-- a/tmp-codegen-diff/aws-sdk/sdk/timestreamwrite/Cargo.toml
        3282  +
++ b/tmp-codegen-diff/aws-sdk/sdk/timestreamwrite/Cargo.toml
 2927   3283   
@@ -1,61 +1,61 @@
 2928   3284   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2929   3285   
[package]
 2930   3286   
name = "aws-sdk-timestreamwrite"
 2931   3287   
version = "0.0.0-local"
 2932   3288   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2933   3289   
description = "AWS SDK for Amazon Timestream Write"
 2934   3290   
edition = "2021"
 2935   3291   
license = "Apache-2.0"
 2936   3292   
repository = "https://github.com/awslabs/aws-sdk-rust"
 2937   3293   
rust-version = "1.86.0"
 2938   3294   
readme = "README.md"
 2939   3295   
[package.metadata.smithy]
 2940   3296   
codegen-version = "ci"
 2941   3297   
[package.metadata.docs.rs]
 2942   3298   
all-features = true
 2943   3299   
targets = ["x86_64-unknown-linux-gnu"]
 2944   3300   
[dependencies.aws-credential-types]
 2945   3301   
path = "../aws-credential-types"
 2946   3302   
version = "1.2.4"
 2947   3303   
 2948   3304   
[dependencies.aws-runtime]
 2949   3305   
path = "../aws-runtime"
 2950   3306   
version = "1.5.9"
 2951   3307   
 2952   3308   
[dependencies.aws-smithy-async]
 2953   3309   
path = "../aws-smithy-async"
 2954   3310   
version = "1.2.5"
 2955   3311   
 2956   3312   
[dependencies.aws-smithy-http]
 2957   3313   
path = "../aws-smithy-http"
 2958         -
version = "0.62.2"
        3314  +
version = "0.62.3"
 2959   3315   
 2960   3316   
[dependencies.aws-smithy-json]
 2961   3317   
path = "../aws-smithy-json"
 2962   3318   
version = "0.61.4"
 2963   3319   
 2964   3320   
[dependencies.aws-smithy-runtime]
 2965   3321   
path = "../aws-smithy-runtime"
 2966   3322   
features = ["client"]
 2967   3323   
version = "1.8.5"
 2968   3324   
 2969   3325   
[dependencies.aws-smithy-runtime-api]
 2970   3326   
path = "../aws-smithy-runtime-api"
 2971   3327   
features = ["client", "http-02x"]
 2972   3328   
version = "1.8.5"
 2973   3329   
 2974   3330   
[dependencies.aws-smithy-types]
 2975   3331   
path = "../aws-smithy-types"
 2976   3332   
version = "1.3.2"
 2977   3333   
 2978   3334   
[dependencies.aws-types]
 2979   3335   
path = "../aws-types"
 2980   3336   
version = "1.3.8"
 2981   3337   
 2982   3338   
[dependencies.bytes]
 2983   3339   
version = "1.4.0"
 2984   3340   
 2985   3341   
[dependencies.fastrand]
 2986   3342   
version = "2.0.0"
 2987   3343   
 2988   3344   
[dependencies.http]
 2989   3345   
diff --git a/tmp-codegen-diff/aws-sdk/sdk/transcribestreaming/Cargo.toml b/tmp-codegen-diff/aws-sdk/sdk/transcribestreaming/Cargo.toml
 2990   3346   
index 5b35037..9fb220a 100644
 2991         -
-- a/tmp-codegen-diff/aws-sdk/sdk/transcribestreaming/Cargo.toml
        3347  +
++ b/tmp-codegen-diff/aws-sdk/sdk/transcribestreaming/Cargo.toml
 2992   3348   
@@ -1,71 +1,71 @@
 2993   3349   
# Code generated by software.amazon.smithy.rust.codegen.smithy-rs. DO NOT EDIT.
 2994   3350   
[package]
 2995   3351   
name = "aws-sdk-transcribestreaming"
 2996   3352   
version = "0.0.0-local"
 2997   3353   
authors = ["AWS Rust SDK Team <aws-sdk-rust@amazon.com>", "Russell Cohen <rcoh@amazon.com>"]
 2998   3354   
description = "AWS SDK for Amazon Transcribe Streaming Service"
 2999   3355   
edition = "2021"
 3000   3356   
license = "Apache-2.0"
 3001   3357   
repository = "https://github.com/awslabs/aws-sdk-rust"
 3002   3358   
rust-version = "1.86.0"
 3003   3359   
readme = "README.md"
 3004   3360   
[package.metadata.smithy]
 3005   3361   
codegen-version = "ci"
 3006   3362   
[package.metadata.docs.rs]
 3007   3363   
all-features = true
 3008   3364   
targets = ["x86_64-unknown-linux-gnu"]
 3009   3365   
[dependencies.aws-credential-types]
 3010   3366   
path = "../aws-credential-types"
 3011   3367   
version = "1.2.4"
 3012   3368   
 3013   3369   
[dependencies.aws-runtime]
 3014   3370   
path = "../aws-runtime"
 3015   3371   
features = ["event-stream"]
 3016   3372   
version = "1.5.9"
 3017   3373   
 3018   3374   
[dependencies.aws-sigv4]
 3019   3375   
path = "../aws-sigv4"
 3020         -
version = "1.3.3"
        3376  +
version = "1.3.4"
 3021   3377   
 3022   3378   
[dependencies.aws-smithy-async]
 3023   3379   
path = "../aws-smithy-async"
 3024   3380   
version = "1.2.5"
 3025   3381   
 3026   3382   
[dependencies.aws-smithy-eventstream]
 3027   3383   
path = "../aws-smithy-eventstream"
 3028   3384   
version = "0.60.10"
 3029   3385   
 3030   3386   
[dependencies.aws-smithy-http]
 3031   3387   
path = "../aws-smithy-http"
 3032   3388   
features = ["event-stream"]
 3033         -
version = "0.62.2"
        3389  +
version = "0.62.3"
 3034   3390   
 3035   3391   
[dependencies.aws-smithy-json]
 3036   3392   
path = "../aws-smithy-json"
 3037   3393   
version = "0.61.4"
 3038   3394   
 3039   3395   
[dependencies.aws-smithy-runtime]
 3040   3396   
path = "../aws-smithy-runtime"
 3041   3397   
features = ["client"]
 3042   3398   
version = "1.8.5"
 3043   3399